From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14454 invoked by alias); 15 Aug 2014 15:27:44 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 14417 invoked by uid 89); 15 Aug 2014 15:27:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 15 Aug 2014 15:27:41 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Aug 2014 16:27:37 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 15 Aug 2014 16:27:35 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1D8AB1B0806B for ; Fri, 15 Aug 2014 16:28:28 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s7FFRY5M31522854 for ; Fri, 15 Aug 2014 15:27:34 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s7FFRY5V018367 for ; Fri, 15 Aug 2014 09:27:34 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-196.boeblingen.de.ibm.com [9.152.212.196]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s7FFRXMs018356; Fri, 15 Aug 2014 09:27:33 -0600 From: Andreas Arnez To: Gary Benson Cc: Joel Brobecker , Mike Frysinger , gdb@sourceware.org Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> <20140814132939.GH4924@adacore.com> <20140815084819.GB30130@blade.nx> <20140815121102.GB6019@adacore.com> <20140815130913.GA1954@blade.nx> <20140815132816.GC6019@adacore.com> <20140815150202.GA5674@blade.nx> Date: Fri, 15 Aug 2014 15:27:00 -0000 In-Reply-To: <20140815150202.GA5674@blade.nx> (Gary Benson's message of "Fri, 15 Aug 2014 16:02:02 +0100") Message-ID: <877g29srh6.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14081515-5024-0000-0000-000000FFA737 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00055.txt.bz2 On Fri, Aug 15 2014, Gary Benson wrote: > Joel Brobecker wrote: >> > Does anybody have any experience writing such checks? Or, does >> > anybody know of any project that already uses such checks? I can >> > look into doing it myself (it's a pre-receive hook, right?) >> >> I have loads of experience writing git hooks, but none with >> this repository's implementation. >> >> I would typically adjust the "update" hook for that, but it looks >> like the "pre-receive" hook would also work. > > I've put together a quick pre-receive hook (inlined below). Each > received commit on the "master" branch that touches the "gdb" > subdirectory gets its message checked. The check itself is fairly > cursory: it splits the message using the "YYYY-MM-DD NAME " > headers, checks each is preceeded by a path starting with "gdb/" and > ending with "/", and checks each is followed by more "NAME " > lines, blank lines, or lines starting with tab. I don't know how > comprehensive we want to be here as the message should already have > been checked over by the reviewer. Maybe (for now) we also want to check that the same ChangeLog entries appear in the patch? > I've never done anything server-side with git before, so there may > well be things I'm missing here. I was mainly experimenting to see > how difficult this all was :) > > Cheers, > Gary