From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12159 invoked by alias); 3 Sep 2014 20:54:00 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 12142 invoked by uid 89); 3 Sep 2014 20:53:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Sep 2014 20:53:58 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s83KqqCL006931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 3 Sep 2014 16:52:52 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s83KqpsG018707 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 3 Sep 2014 16:52:52 -0400 From: Sergio Durigan Junior To: Joel Brobecker Cc: Gary Benson , gdb@sourceware.org, Andreas Arnez , Doug Evans Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> X-URL: http://www.redhat.com Date: Wed, 03 Sep 2014 20:54:00 -0000 In-Reply-To: <20140814125224.GF4924@adacore.com> (Joel Brobecker's message of "Thu, 14 Aug 2014 05:52:24 -0700") Message-ID: <8761h4fmu4.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00006.txt.bz2 On Thursday, August 14 2014, Joel Brobecker wrote: >> 3. With paths but no date-and-author headers: >> >> gdb/ChangeLog: >> >> * amd64-windows-tdep.c (amd64_windows_frame_decode_insns): >> Add debug trace. > #3, since date and author are often redundant with the commit's > author. And even if not in the same, it's in the ChangeLog entry > that should be checked in as part of the commit. Also, I feel > like having those in the CL is an extra source of potential > issue (eg: if forgot to update the date), and revision logs > cannot be fixed once the commit has been pushed, whereas dates > in ChangeLog entries can. Sorry for reopening this discussion, but I would like to propose another change. I understand Joel's arguments above, and even agreed with them when I read, but I'm not so sure anymore. Yesterday Doug asked something interesting in the channel. He was trying to figure out the date when 860789c7 was pushed. From git log: commit 860789c7d5d6ef2f60e757feb21845bb230582a8 Author: Gary Benson Date: Fri Aug 8 15:37:41 2014 +0100 Use exceptions and cleanups in gdbserver This commit replaces the hacky "exception" system in gdbserver with the exceptions and cleanups subsystem from GDB. Only the catch/cleanup code in what was "main" has been updated to use the new system. Other parts of gdbserver can now be converted to use TRY_CATCH and cleanups on an as-needed basis. A side-effect of this commit is that some error messages will change slightly, and in cases with multiple errors the error messages will be printed in a different order. gdb/gdbserver/ChangeLog: * server.h (setjmp.h): Do not include. (toplevel): Do not declare. (common-exceptions.h): Include. (cleanups.h): Likewise. * server.c (toplevel): Do not define. (exit_code): New static global. (detach_or_kill_for_exit_cleanup): New function. (main): New function. Original main renamed to... (captured_main): New function. * utils.c (verror) [!IN_PROCESS_AGENT]: Use throw_verror. However, this is not the push date; instead, this is the date Gary committed the changes in his local repository. If you go see the ChangeLog referred in the commit message, you will see that the actual push date was 2014-08-29. While I understand the reasons for git to do that, I find it a bit annoying to be "deceived" this way, and not have the push date readily available in the commit message. Maybe there's an easy way to recover this information from git (though I couldn't find it), and if there is, then disconsider my message. However, there doesn't seem to be any straightforward way to recover the push date. So, what I propose is simple: let's add the date and the author back in the ChangeLog entry that is present in the commit message. It would make things a bit easier, at least from my perspective. WDYT? Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/