From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7jeGFyzh8WTnVQ8AWB0awg (envelope-from ) for ; Fri, 01 Sep 2023 09:03:40 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lAs44TWt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 524491E0C2; Fri, 1 Sep 2023 09:03:40 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 248CE1E092 for ; Fri, 1 Sep 2023 09:03:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 505083882648 for ; Fri, 1 Sep 2023 13:03:20 +0000 (GMT) Received: from omta037.useast.a.cloudfilter.net (omta037.useast.a.cloudfilter.net [44.202.169.36]) by sourceware.org (Postfix) with ESMTPS id 80E60388200E for ; Fri, 1 Sep 2023 13:02:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80E60388200E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTP id c1FjqG8pKWU1cc3nTqazQ5; Fri, 01 Sep 2023 13:02:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id c3nRqw75Op4nAc3nSqsh2h; Fri, 01 Sep 2023 13:02:46 +0000 X-Authority-Analysis: v=2.4 cv=AI0h59Ht c=1 sm=1 tr=0 ts=64f1e0f6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=zNV7Rl7Rt7sA:10 a=Qbun_eYptAEA:10 a=IiTWPmVrcI5hGNu3it0A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=enpJ49WhmH9P93MWUHU55ZcMQ7RwKPBmX+LWWKlucLk=; b=lAs44TWtTpsc/C6T0/Qzc15Ouo UYm+21eKOjE9oHeQxOYPpE1N+hTab7RFp7iHOpEVuI0aHDXIcRtNbC1WhDH9/WPN4RsWKa+3pBXbJ p2lgRlftUN5od06kDVCbGuOwN; Received: from 75-166-150-212.hlrn.qwest.net ([75.166.150.212]:43950 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qc3nR-0012MV-1p; Fri, 01 Sep 2023 07:02:45 -0600 From: Tom Tromey To: Martin Simmons Cc: gdb@sourceware.org Subject: Re: GDB13 fails to build on MacOS using supplied GNU Bison 2.3 References: <0badf084-d0b7-54bb-aec6-b79f29ad191d@foss.st.com> <87jztbpccn.fsf@tromey.com> <0007c884-16a1-2fe3-e574-d9fe5c944c83@foss.st.com> <87bkenoxvf.fsf@tromey.com> X-Attribution: Tom Date: Fri, 01 Sep 2023 07:02:45 -0600 In-Reply-To: (Martin Simmons's message of "Fri, 01 Sep 2023 11:51:21 +0100") Message-ID: <875y4uoxl6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.150.212 X-Source-L: No X-Exim-ID: 1qc3nR-0012MV-1p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-150-212.hlrn.qwest.net (murgatroyd) [75.166.150.212]:43950 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOVsVODOPXzAOkjVZBNMKpjZMnhYi64X1u1CezLqeR0AYmZYTOD3MJ0wTag42250K16TgnCbk7D++NHXCXVLaN3t7ZYPW/KR298VX3qe4h3tmwM8EP9I 3xuQg2y2kCILbZIeLSSnXKBqhmOVU/TsFDrc0RREzO5iPoEtMGFVYb3gprKim56x0Tva1ejZJ4R0+Q== X-Spam-Status: No, score=-3024.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" Martin> Also need to patch gdb/split-name.c? Really thought I built it but apparently not. Thanks. Tom diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c index d6531260c86..58ea541a5c9 100644 --- a/gdb/dwarf2/cooked-index.c +++ b/gdb/dwarf2/cooked-index.c @@ -267,7 +267,7 @@ cooked_index_shard::handle_gnat_encoded_entry (cooked_index_entry *entry, if (canonical.empty ()) return {}; std::vector names = split_name (canonical.c_str (), - split_style::DOT); + split_style::DOT_STYLE); gdb::string_view tail = names.back (); names.pop_back (); diff --git a/gdb/split-name.c b/gdb/split-name.c index a50a6fa4946..0253b3cf675 100644 --- a/gdb/split-name.c +++ b/gdb/split-name.c @@ -58,7 +58,7 @@ split_name (const char *name, split_style style) } break; - case split_style::DOT: + case split_style::DOT_STYLE: /* D and Go-style names. */ for (const char *iter = strchr (name, '.'); iter != nullptr; diff --git a/gdb/split-name.h b/gdb/split-name.h index 47896cc4406..7648cf9b900 100644 --- a/gdb/split-name.h +++ b/gdb/split-name.h @@ -30,8 +30,9 @@ enum class split_style NONE, /* C++ style, with "::" and template parameter intelligence. */ CXX, - /* Split at ".". Used by Ada, Go, D. */ - DOT, + /* Split at ".". Used by Ada, Go, D. This has a funny name to work + around a bug in Bison 2.3, which is used on macOS. */ + DOT_STYLE, /* Split at "__". Used by Ada encoded names. */ UNDERSCORE, }; diff --git a/gdb/symtab.h b/gdb/symtab.h index ca3b1a4a0b6..8f587807ff9 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -305,7 +305,7 @@ class lookup_name_info final break; case language_d: case language_go: - style = split_style::DOT; + style = split_style::DOT_STYLE; break; } return ::split_name (language_lookup_name (lang), style);