From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id N4WsHMQbEmV6+RwAWB0awg (envelope-from ) for ; Mon, 25 Sep 2023 19:46:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=TUa1x3PF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 66F941E0C3; Mon, 25 Sep 2023 19:46:12 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59F7C1E028 for ; Mon, 25 Sep 2023 19:46:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BEECB3856975 for ; Mon, 25 Sep 2023 23:46:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEECB3856975 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695685569; bh=EXreX7EGj3DAZ1DB9S/4XHvaiv4ZZRs1UGRIuiN2p9U=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=TUa1x3PFKyiZLE6yn0dLXRFvJk71DoU4aXCW4p4G3G1QlLBtsJoNpUJosYaA/xjwB xjIzrNsyY0pIaj76wP53DYXSiFsHc9+QT4pCMgen73uG8YaMKtkmH9+KapV7Xtv1Pi 2Ew+2br8XaJ1wUufEV2vnuv2kAg+i39+JCYiTQIQ= Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050:0:465::102]) by sourceware.org (Postfix) with ESMTPS id DEF173858D3C for ; Mon, 25 Sep 2023 23:45:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEF173858D3C Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4RvfdH0Y55z9slt; Tue, 26 Sep 2023 01:45:39 +0200 (CEST) To: Enze Li Cc: Gdb Subject: Re 2da39de "fbsd-nat: Pacify gcc with no functional changes" Date: Tue, 26 Sep 2023 01:39:48 +0200 Message-ID: <86o7hpx1eo.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?Arsen_Arsenovi=C4=87_via_Gdb?= Reply-To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, This patch seems to have broken building GDB on x86_64-portbld-freebsd13.1 for me. In the following hunk... @@ -2094,6 +2092,9 @@ fbsd_nat_target::detach (inferior *inf, int from_tt= y) } } } +#else + /* pacify gcc */ + wptid =3D (void) null_ptid; #endif sig =3D 0; break; ... in the #else branch, there's a cast which I can't discern the purpose of. The type of wptid is the same as the type of null_ptid, and a cast to void as an rvalue doesn't make sense. Dropping the cast results in the build working again (and no warnings). Did you mean for this line to be 'wptid =3D null_ptid'? TIA, have a lovely night :-) =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZRIbn18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST9W0A/1MMoV3vox1aPe90HaawjCENL5C1EZmBXg9Y 40j5HVpRAQCAEJc51Zpx9JOljugGAAObDw/OINfNMNER6ou0DqeaAg== =Frl1 -----END PGP SIGNATURE----- --=-=-=--