From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EcjbGT0f3WhuKRsAWB0awg (envelope-from ) for ; Wed, 01 Oct 2025 08:31:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CScxztyj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 664391E047; Wed, 01 Oct 2025 08:31:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D52D61E047 for ; Wed, 01 Oct 2025 08:31:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79E9E385843F for ; Wed, 1 Oct 2025 12:31:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 79E9E385843F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1759321916; bh=NjEH5E6lZPUm/Nls21MeLZt6HUjOUJ8A3AllqiJeLAw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CScxztyjwRH8TBd4iQKg8LsbhFObWN/JDSYBh6ufLtPxbB7sepOnAPqZ6a9YlZHN5 SWUqC06d/Hy5dAyc6Dba6VruSgt2PP/vUc8gIbJTLY7YQvRdqrBUavoGZJamJiQgm0 vmpz0DLxzJBqyErN+HG13xJARQ4R5Mjtpmg8qk8Q= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 83A323858C24 for ; Wed, 1 Oct 2025 12:30:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83A323858C24 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83A323858C24 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759321851; cv=none; b=YwS/OMIMJlNPggsF+JtvX+EdQPV8kBRKzm0DDx78WoCWaoY+N0e3HJA6IrWVdsiH6FihwmXS82dySn4F5d+yKSxrFArHijN03eFR/DTAhDOCyZpSBB2zVXpMxsrsKVkeb6hEi3gmBlrACqBZsN2uMHlkRGrnobR/JXOYHHMPfQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759321851; c=relaxed/simple; bh=ouZQLLQzZnSU7gsPyFlvU1SHQVeFgdAt5VgajDnskvo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=T4Jb/dNEtJ5VkGgK9ZcSXPpz31nFlTZPwB4IwT1xYNoc/WB5gGmtORC1qUfQQykt+t/NaiwN8IlEgSJJ6UtdG7ROicf4WuJUjHU+b79N2mIE3OX4EV+u5/fxbwJIzZmUuGoAXlG8IMBASpE7n+gMMTsOsJNbejhDi1XFc9+nPMA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83A323858C24 Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208--6ULkCF-MRuQRg9BNSaLPw-1; Wed, 01 Oct 2025 08:30:50 -0400 X-MC-Unique: -6ULkCF-MRuQRg9BNSaLPw-1 X-Mimecast-MFC-AGG-ID: -6ULkCF-MRuQRg9BNSaLPw_1759321849 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-28e8112143fso12006605ad.2 for ; Wed, 01 Oct 2025 05:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759321849; x=1759926649; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NjEH5E6lZPUm/Nls21MeLZt6HUjOUJ8A3AllqiJeLAw=; b=UacPi6VGSvcGHu7FPb32Lpydhq6vI6AgisSh/o41dUoJzzowLaF40UWgNUgoDm5N+P gTIbBnkMYdoQE5nmQYQA5gWp6yFiBsXAA7xbtikQkNRxiPdG7bK0ynWG+GCO05oU740+ jVMo+Kzqf6frJqg9rl66Z7IKBFF/gxcCBsIjw+FaGxjCL3cGT5uR32jIoIBBM24QYbgb Ewwx4pghMp4CSmdpJdwMCwUwJ0I5f3QaBxzDStdDPsZM97JSqWN/zjBmH3JUGKhf7/kf sQhXLryPzX0XvarhAsEoZpHVsH7TXBUNkwNHghHPC/nDx32FFjliYuH89bXi7yPme5dJ JL9g== X-Forwarded-Encrypted: i=1; AJvYcCU1ArokWfLFfnubWhz2kJD1qZe3yDoZCHTyDRT1cGAqBi7xokZZz0CgbMb/lvbDyFR4AR0=@sourceware.org X-Gm-Message-State: AOJu0YzuLHCO8mIfdNixxJwaofJbt1EAnrnNGmbbMu09nfr4HDOXRbvr xct9UENEfNS99G3KfyBV9XBQF4dRRRdUzibT6JN2YTozBV6pp5K76wujV67gl5dWBONkxHVctIF MmsdzvHqcElo/BhB7dbD3HxnLx20+s1C/w21ICg323U9Dzgm5LuJa X-Gm-Gg: ASbGnctGY6Q7bf0cMoJvS/QhhuvnvbXKtYUaOWudNv41Z8LCRQmNyzlWC/I7kx3XIPH 8BQddjgDExxDESr6Zl/PhdzSlP/MitpyE89/a2PHTSoLjjxPIAm/EkhnAN2VWTqZa+vtQq2nhB0 E7GPRIMlsyscOGuxPuHl0lpbu4kThSueu0mcErd6N+XvFxZvkgeOpRX//ot07WILUT0vl2oaU+Z iRt+FJ/xkmNq2DQTYa09ZvRHvMz91uNf6+QlBL87vayDp5U2oAEmKwnKbzZc8hKzJ2F2J4UvSmG OWfMXhd2qFtfFrlT2+82tytrecJnQRxzNvGKInaoiUmvKBYYofNTMB4l1w== X-Received: by 2002:a17:902:d4c2:b0:271:5bde:697e with SMTP id d9443c01a7336-28e7f2f5ebfmr42203635ad.3.1759321848962; Wed, 01 Oct 2025 05:30:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRFQHyJKOtNs3mnhLENc1w/8QSpATVW4Sywzufi2LuqGtC/LsC+l9o66wjymr/jTx3tMtzQA== X-Received: by 2002:a17:902:d4c2:b0:271:5bde:697e with SMTP id d9443c01a7336-28e7f2f5ebfmr42203335ad.3.1759321848536; Wed, 01 Oct 2025 05:30:48 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed68a02fdsm186112515ad.97.2025.10.01.05.30.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 05:30:47 -0700 (PDT) Message-ID: <86938ac5-3281-4681-83f5-1a9d6886054a@redhat.com> Date: Wed, 1 Oct 2025 09:30:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: tclint, pre-commit and patch submissions To: Tom de Vries , gdb-patches , "gdb@sourceware.org" References: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> In-Reply-To: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gWmJcSttqbrIxXiKQjBvssVXEciodImX2VMYT5u56AM_1759321849 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Guinevere Larsen via Gdb Reply-To: Guinevere Larsen Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 10/1/25 8:55 AM, Tom de Vries wrote: > Hi, > > I've recently added a tclint pre-commit hook, and started cleaning the > testsuite. > > The current status is that all gdb.* dirs are done, with the exception > of gdb.stabs (which is going to be removed, so I skipped it). > > My question is what to do with patches adding new test-cases or > modifying existing test-cases. > > If these patches are not tclint-clean, then after commit this command: > ... > $ pre-commit run tclint --all-files > ... > will start showing new tclint errors. > > One thing that could be done at that point is to ask the > submitter/committer to fix the tclint errors. > > But there's no formal agreement atm that this need to be fixed. I've > proposed the hook, and Tom Tromey approved it, but that's just two > maintainers. I think using a linter is good, and making new submissions clean for that linter is something worthwhile. IMO, when approving a patch, we could just mention the TCL lint output as nits to be fixed before a patch is pushed. > > So I'd like to know the opinion of other maintainers. > > Possible outcomes of this discussion could be that: > - we get rid of tclint in pre-commit and forget about it > - we drop one or more error categories in gdb/tclint.toml > - we require submitters to run pre-commit before submission > - we make the repo refuse commits that are not pre-commit clean > - nothing changes, and submitters can use all/some/no pre-commit hooks >   for their own submissions > > Thanks, > - Tom > -- Cheers, Guinevere Larsen It/she