From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb@sourceware.org
Subject: Re: Breakpoint commands in MI mode and "backtrace"
Date: Sun, 08 Oct 2017 18:27:00 -0000 [thread overview]
Message-ID: <83shetsdg2.fsf@gnu.org> (raw)
In-Reply-To: <8a3d7153-7486-032f-aabc-6c3453f96459@simark.ca> (message from Simon Marchi on Sun, 8 Oct 2017 13:51:39 -0400)
> From: Simon Marchi <simark@simark.ca>
> Date: Sun, 8 Oct 2017 13:51:39 -0400
>
> It seems like even though we are executing CLI commands, the current interpreter
> and uiout are the MI ones. I'm always confused by all these data structures, but
> I managed to hack it to work with this:
>
> diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
> index 0a93e8b54f..bc8e1047c5 100644
> --- a/gdb/cli/cli-script.c
> +++ b/gdb/cli/cli-script.c
> @@ -482,7 +482,10 @@ execute_control_command (struct command_line *cmd)
> {
> /* A simple command, execute it and return. */
> std::string new_line = insert_user_defined_cmd_args (cmd->line);
> - execute_command (&new_line[0], 0);
> +
> + scoped_restore_interp restorer (INTERP_CONSOLE);
> + current_interpreter ()->exec (&new_line[0]);
> +
> ret = cmd->control_type;
> break;
> }
>
> Does that work for you? It might not be the right solution, but it's a start.
This doesn't compile when applied to GDB 8.0 code. Can the same be
done with the scoped_restore class instead?
In any case, there are more instances of calls to execute_command in
that function, and I guess they all need to be changed like that?
Thanks.
next prev parent reply other threads:[~2017-10-08 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 10:08 Eli Zaretskii
[not found] ` <8a3d7153-7486-032f-aabc-6c3453f96459@simark.ca>
2017-10-08 18:27 ` Eli Zaretskii [this message]
2017-10-08 19:24 ` Simon Marchi
2017-10-08 20:03 ` Eli Zaretskii
2017-10-09 4:16 ` Simon Marchi
2017-10-09 7:27 ` Eli Zaretskii
2017-10-09 7:52 ` Eli Zaretskii
2017-10-09 12:02 ` Simon Marchi
2017-10-09 12:59 ` Eli Zaretskii
2017-10-21 8:26 ` Eli Zaretskii
2017-10-21 14:13 ` Simon Marchi
2017-10-21 16:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shetsdg2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox