From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zfdzB9V75GAoRgAAWB0awg (envelope-from ) for ; Tue, 06 Jul 2021 11:50:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 1689C1F1F4; Tue, 6 Jul 2021 11:50:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 693A61F1F0 for ; Tue, 6 Jul 2021 11:50:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF1E9388F01A for ; Tue, 6 Jul 2021 15:50:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF1E9388F01A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625586643; bh=Gm7mMNUbnsb3JeKiOXJIh8XwYjJ0zHP6Wkq01W6HxL0=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tDghlk5YAdAIbgL6o6kQ+yRqkw+phHzUq0g+P3MNQu3+W0vIrE1x8phK/tM8xEBSr KSKooqSLmUHdyBf61BkOkH2ng6vvvqrEL35xcqgAMRERakt7oY0rqYQbkC2HyBDzOX C4SFF5XWj+nqhDwB2yEq2yjLaxiCXVDu1fMR+7TA= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id DDE35383A831 for ; Tue, 6 Jul 2021 15:50:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDE35383A831 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47676) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0nKz-0002Y1-B7; Tue, 06 Jul 2021 11:50:17 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4279 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0nKy-0000rn-Uv; Tue, 06 Jul 2021 11:50:17 -0400 Date: Tue, 06 Jul 2021 18:50:26 +0300 Message-Id: <83h7h7fnlp.fsf@gnu.org> To: Tom de Vries In-Reply-To: <8731b5b6-814f-8559-d72e-b8c86e2ee6d7@suse.de> (message from Tom de Vries on Tue, 6 Jul 2021 16:58:28 +0200) Subject: Re: [ANNOUNCEMENT] GDB 11 release branch created! References: <87im1q78im.fsf@linux-m68k.org> <78ca1c45-beb3-966f-e995-912bc1e115c1@suse.de> <83h7h9gcu8.fsf@gnu.org> <83czrwhj02.fsf@gnu.org> <8731b5b6-814f-8559-d72e-b8c86e2ee6d7@suse.de> X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb Reply-To: Eli Zaretskii Cc: gdb@sourceware.org, tom@tromey.com, bernd.edlinger@hotmail.de, brobecker@adacore.com Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" > Cc: brobecker@adacore.com, tom@tromey.com, bernd.edlinger@hotmail.de, > gdb@sourceware.org > From: Tom de Vries > Date: Tue, 6 Jul 2021 16:58:28 +0200 > > > Therefore, I tried to propose a band-aid: > > have the readline/readline/doc directory be _always_ on the makeinfo's > > include path, so that if someone reconfigures GDB like in the > > reproducer, they still get a successful build, albeit with a couple of > > sections in the manual they don't need. > > AFAIU, the problem is not that users get a couple of sections in the > manual they don't need. The problem is that the users get the incorrect > version of a section of the manual. I think this is a minor problem. How different could be the Readline we have in the tarball vs the one installed on the user's system? Readline is a relatively stable package, so changes are likely minor. > I did this: > ... > - READLINE_TEXI_INCFLAG= > + READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)' > ... > in src/gdb/configure and managed to finish the build. So my recommendation is to go with this solution on the release branch. I will try to think about a cleaner fix on master. > I'd say the easiest way to fix the problem is to revert the commit that > introduced the problem. I wouldn't recommend that. In fact, I do have Texinfo installed, but I nevertheless am always slightly annoyed by the fact that building GDB always rebuilds the Info manual for some reason. I hope that commit solved this. Joel, it's your call.