Re: [PATCH] Fix 5-line offset of edit command

[Eli Zaretskii via Gdb <gdb@sourceware.org>]

> Date: Sat, 11 Feb 2023 14:52:33 -0800
> From: Gary Johnson <garyjohn@spocom.com>
> 
> > > The problem appears to be in the edit_command() function in
> > > cli-cmds.c, at line 966 in version 12.1.  The solution is to
> > > delete that line.  The patch is below.
> > 
> > This is probably editor-specific?
> 
> No, it's not editor-specific.  The command to run the editor is
> created at the end of the edit_command() function:

I meant the effect is editor-specific.  IOW, what exactly does each
editor display when passed a line number.

> As I recall, this used to work long ago, then something changed and
> the editor was always opened at line 6, then around 2020 it changed
> again to open at the current line plus 5.  I suspect
> a copy-and-paste error, but I haven't looked into the history of
> that function.

I tried to look into the history with "git log -L", but got stuck at
the commit that moved the function from another file.  Maybe some Git
expert could suggest how to cross that line?

> I intended to send this to gdb-patches, but it looks like I wasn't
> paying attention to the address and sent it to the general gdb list
> instead.

Yes, it is best to resent to gdb-patches.