Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS

Eli Zaretskii via Gdb
2023-05-16T16:05:23Z

> Cc: gdb@sourceware.org,
> Bruno Larsen <blarsen@redhat.com>
> Date: Tue, 16 May 2023 16:38:27 +0200
> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
>
> + - Tested-by:
> +
> + Used when a contributor does not want to comment on the quality
> + of the code in the patch, but has tested and sees no regressions on their
> + hardware.
> +
> + - Reviewed-by:
> +
> + Used when a contributor has looked at code and agrees with the changes,
> + but either does not have the authority or doesn't feel comfortable
> + approving the patch (usually due to unfamiliarity with a certain
> + part of the code).

Reviewed-by is used by responsible maintainers as well.

> +
> + - Approved-by:
> +
> + Used by responsible mainainers or global maintainers when
^^^^^^^^^^
Typo.

> + a patch is ready to be upstreamed. Some patches may touch multiple areas
> + and require multiple approvals before landing (such as a maintainer only
> + approving documentation), it is up to the maintainer giving the approval tag
> + to make it clear when that a tag is not sufficient.
> + Responsible, Global and Official FSF-appointed maintainers may approve their
> + own patches, but it is recommended that they seek external approval before
> + doing so.
> +

I think the above list is incomplete, because there appears to be no
"git trailer" (why do we have to call it "git" trailer, btw? will
that change if we ever switch to a different VCS?) for the situation
where the responsible maintainer does approve some part of the patch,
but not all of it (e.g., because the other parts are not in the
expertise domain of that maintainer). I thought Reviewed-by is such a
trailer, but based on the above I'm beginning to think I was confused.