From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10860 invoked by alias); 4 May 2006 14:45:50 -0000 Received: (qmail 10851 invoked by uid 22791); 4 May 2006 14:45:49 -0000 X-Spam-Check-By: sourceware.org Received: from nz-out-0102.google.com (HELO nz-out-0102.google.com) (64.233.162.204) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 May 2006 14:45:46 +0000 Received: by nz-out-0102.google.com with SMTP id 14so465939nzn for ; Thu, 04 May 2006 07:45:44 -0700 (PDT) Received: by 10.36.67.9 with SMTP id p9mr21352nza; Thu, 04 May 2006 07:45:44 -0700 (PDT) Received: by 10.36.227.44 with HTTP; Thu, 4 May 2006 07:45:44 -0700 (PDT) Message-ID: <7f45d9390605040745o4c332058te1e289e5d5e9620@mail.gmail.com> Date: Thu, 04 May 2006 14:45:00 -0000 From: "Shaun Jackman" Reply-To: "Shaun Jackman" To: gdb@sources.redhat.com Subject: Modifying a verboten register MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00019.txt.bz2 VGFyZ2V0dGVkIGZvciBhcm0tZWxmLCBnZGIgZG9lcyBub3QgbGV0IG1lIG1v ZGlmeSB0aGUgY3BzciByZWdpc3RlcgpvdXRzaWRlIG9mIGEgIm5vcm1hbCIg ZnJhbWUuCgooZ2RiKSBwL3ggJGNwc3I9MHgzZgpWYWx1ZSBiZWluZyBhc3Np Z25lZCB0byBpcyBubyBsb25nZXIgYWN0aXZlLgoKSSBmaXJzdCByZXBvcnRl ZCB0aGlzIGJ1ZyBvbmUgeWVhciBhZ28gb24gMjAwNS0wNC0yMC4gU28gZmly c3QgdGhpbmcKZmlyc3QsIGEgd2VlIGFubml2ZXJzYXJ5IHBhcnR5IGZvciB0 aGUgYnVnLiAqd2VlZWVlZWVlZXp6enp6enp6enp6enoqCihUaGF0IHdhcyBh IG5vaXNlIG1ha2VyLikKClBhcnRpZXMgYXNpZGUsIHRoZSBKVEFHIGludGVy ZmFjZSBJIHVzZSAoQkRJMjAwMCkgaGFzIGEgY29tbWFuZCBtb2RlCihUZWxu ZXQgaW50ZXJmYWNlKSB0aGF0IEkgY2FuIHVzZSB0byBtb2RpZnkgdGhlIHJl Z2lzdGVyLiBHREIgc2VlbXMgdG8KY2FjaGUgaXRzIHZpZXcgb2YgdGhlIHJl Z2lzdGVycyB0aG91Z2guCgooZ2RiKSBwL3ggJGNwc3IKJDEgPSAweGQ3Cgpb aW4gYSBnYWxheHkgZmFyLCBmYXIgYXdheV0KQkRJPnJtIGNwc3IgMHgzZgpC REk+cmQgY3BzcgpjcHNyOiAweDAwMDAwMDNmICA2MwoKKGdkYikgcC94ICRj cHNyCiQyID0gMHhkNwoKSSBkb24ndCByZWFsbHkgZXhwZWN0IHR3byBzZXBh cmF0ZSB0b29scyB0byBjb29wZXJhdGUgdG8gZGVidWcgdGhlCnNhbWUgY29y ZSwgYnV0IEknbSBzY3JhbWJsaW5nIGZvciBzb21lIChhbnkpIHdvcmthcm91 bmQgdG8gdGhlIGFib3ZlCmJ1Zy4gSSBxdWl0ZSBsaXRlcmFsbHkgc2VlIGl0 ICpldmVyeSogZGF5LiBJdCBtYWtlcyBteSBoZWFkIGh1cnQuCgpDaGVlcnMs ClNoYXVuCg== >From gdb-return-25067-listarch-gdb=sources.redhat.com@sourceware.org Thu May 04 14:51:25 2006 Return-Path: Delivered-To: listarch-gdb@sources.redhat.com Received: (qmail 17810 invoked by alias); 4 May 2006 14:51:24 -0000 Received: (qmail 17797 invoked by uid 22791); 4 May 2006 14:51:23 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 04 May 2006 14:50:56 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FbfAE-0000Dx-O2; Thu, 04 May 2006 10:50:46 -0400 Date: Thu, 04 May 2006 14:51:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Jim Ingham , Nick Roberts , gdb@sources.redhat.com Subject: Re: -var-update and address changes Message-ID: <20060504145046.GA32605@nevyn.them.org> Mail-Followup-To: Vladimir Prus , Jim Ingham , Nick Roberts , gdb@sources.redhat.com References: <200605021740.40193.ghost@cs.msu.su> <1B177ECC-2AD9-4476-AF44-D91F4268E70E@apple.com> <200605031002.21910.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605031002.21910.ghost@cs.msu.su> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Delivered-To: mailing list gdb@sourceware.org X-SW-Source: 2006-05/txt/msg00020.txt.bz2 Content-length: 1561 On Wed, May 03, 2006 at 10:02:21AM +0400, Vladimir Prus wrote: > On Tuesday 02 May 2006 21:22, Jim Ingham wrote: > > Shouldn't the call to var->root->lang->value_of_root down at the > > bottom of value_of_root take care of fetching the new value? > > Well, it fetches the new value, I believe. For the wrong frame. I've only lightly tested this; could you give it a try? If it works, I think we should really get the "@" syntax added to the manual and testsuite. The removed reinit_frame_cache is undoubtedly a performance suck. I see no reason it should be necessary. This code is still dubious; the select_frame call clobbers the selected frame and nothing ever restores it. -- Daniel Jacobowitz CodeSourcery 2006-05-04 Daniel Jacobowitz * varobj.c (c_value_of_root): Honor use_selected_frame. Remove bogus reinit_frame_cache. Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.59 diff -u -p -r1.59 varobj.c --- varobj.c 27 Mar 2006 00:15:22 -0000 1.59 +++ varobj.c 4 May 2006 14:50:03 -0000 @@ -1879,11 +1879,10 @@ c_value_of_root (struct varobj **var_han /* Determine whether the variable is still around. */ - if (var->root->valid_block == NULL) + if (var->root->valid_block == NULL || var->root->use_selected_frame) within_scope = 1; else { - reinit_frame_cache (); fi = frame_find_by_id (var->root->frame); within_scope = fi != NULL; /* FIXME: select_frame could fail */