From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104188 invoked by alias); 19 Oct 2017 17:08:48 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 104149 invoked by uid 89); 19 Oct 2017 17:08:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=H*r:sk:gdb@sou, H*M:64ff, Acked-by, Ackedby X-HELO: mail-qk0-f195.google.com Received: from mail-qk0-f195.google.com (HELO mail-qk0-f195.google.com) (209.85.220.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 17:08:46 +0000 Received: by mail-qk0-f195.google.com with SMTP id b15so11210089qkg.9 for ; Thu, 19 Oct 2017 10:08:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=igjdFXf52gjQzqE4XLfPeREQw3qJ7OhBAMdNzKuoiXY=; b=naMZRmRL0vNqFLL4pkNXk8shRols+P9XUoH7WzyrpORYYpOzHsplCQ/mia7znSpsh+ x7SHRFTsA54TgAJNg09rKGZROv/5kjZ7uaJ0LSGgusBFok8XDaB68K5o0/ApNz0EHcbY XdMRxG8f5OmZWklS+SRjgW9R1nhARqqy3epx5q4E+6KDbmSoIDkiI8NjMukNQVISHcsb 2SWQHyDSBZS9HvQLA1iwuJRZalWSrPwlhC+BAPDMRBkOoXqtxIr06731+KS9bY3G8Moz jHtuZiP8ZpObiqGA/fvcm0pLf7hjYAIqZb98NMOOP1vP7w5/dK2CTaBXTHTCanXY1Uqf 5QrA== X-Gm-Message-State: AMCzsaWbru9Xn4OAR9XI4DvcOJ4ncVLr6jOE56NEzJPuT13HiiUxNO6d B34An1VZwPjvjfceDWINEkGPJQ== X-Google-Smtp-Source: ABhQp+TlpHnyxbz2Ixiueeg7lMNxWly7O+6sK+KpYj3VmAu0zTVj66YRclWfy5DIQYtsgqlDRjSYdQ== X-Received: by 10.55.141.135 with SMTP id p129mr2894708qkd.358.1508432924373; Thu, 19 Oct 2017 10:08:44 -0700 (PDT) Received: from [10.150.73.190] ([184.151.231.188]) by smtp.gmail.com with ESMTPSA id d25sm9893297qtc.7.2017.10.19.10.08.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 10:08:43 -0700 (PDT) Subject: Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc. To: Joseph Myers , Thomas Schwinge Cc: gcc@gcc.gnu.org, Gerald Pfeifer , Richard Biener , gdb@sourceware.org, binutils@sourceware.org, libc-alpha@sourceware.org References: <87zi9oj8rl.fsf@euler.schwinge.homeip.net> <347AE883-971C-447C-AB07-43F7F70F25D3@gmail.com> <4056e466-3055-455b-9922-55497d21fd80@redhat.com> <87tvzuk29t.fsf@euler.schwinge.homeip.net> <87376zja8d.fsf@euler.schwinge.homeip.net> <87shefi100.fsf@euler.schwinge.homeip.net> From: Carlos O'Donell Message-ID: <7964fb3c-f360-3143-64ff-af51063b5dbe@redhat.com> Date: Thu, 19 Oct 2017 17:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00063.txt.bz2 On 10/19/2017 09:45 AM, Joseph Myers wrote: > On Thu, 19 Oct 2017, Thomas Schwinge wrote: > >> Hi! >> >> Still waiting for any kind of reaction -- general process-change inertia, >> chicken-and-egg problem, I suppose. ;-/ >> >> I have now put the proposed text onto a wiki page, so that those >> interested have a convenient handle to use, >> . > > That wiki page refers to Reviewed-by as being about crediting reviewers. > But the specification appears to be oriented to something else entirely > (i.e. convincing a committer - in a Linux-kernel-like context with a very > limited set of committers to a particular tree, much smaller than the set > of reviewers - that a patch is worthy of commit). It doesn't cover > reviews that request changes, or only relate to part of a patch, or relate > to a previous version of a patch - only the limited special case of a > review approving the entirety of a patch as posted. If the aim is credit, > a substantially different specification is needed. If a person is requesting changes, they should after accepting the changes, submit a 'Reviewed-by:' tag or 'Acked-by:' tag to indicate they are happy with the results? -- Cheers, Carlos.