From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72880 invoked by alias); 17 Oct 2017 12:01:43 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 72719 invoked by uid 89); 17 Oct 2017 12:01:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1721 X-HELO: hqemgate15.nvidia.com Received: from hqemgate15.nvidia.com (HELO hqemgate15.nvidia.com) (216.228.121.64) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 12:01:41 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com id ; Tue, 17 Oct 2017 05:01:00 -0700 Received: from HQMAIL106.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 17 Oct 2017 05:01:12 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 17 Oct 2017 05:01:12 -0700 Received: from UKMAIL102.nvidia.com (10.26.138.15) by HQMAIL106.nvidia.com (172.18.146.12) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 17 Oct 2017 12:00:42 +0000 Received: from localhost.localdomain (10.21.45.12) by UKMAIL102.nvidia.com (10.26.138.15) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 17 Oct 2017 12:00:39 +0000 To: GDB Development CC: Yao Qi From: Dmitry Antipov Subject: Dummy leftover in d3037ba6a398d37585b3d34ff9ed439848ba98a1 Message-ID: <6cfccaca-31c2-d994-f8c1-fda3f72224e3@nvidia.com> Date: Tue, 17 Oct 2017 12:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL102.nvidia.com (10.26.138.15) X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00047.txt.bz2 g++ -x c++ -O0 -g3 -I. -I../../gdb -I../../gdb/common -I../../gdb/config= -DLOCALEDIR=3D"\"/home/dantipov/.local/gdb-8.0.50/share/locale\"" -DHAVE_C= ONFIG_H -I../../gdb/../include/opcode=20 -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../../gdb/../zlib -I= ../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../= gdb/../libdecnumber -I../../gdb/gnulib/import=20 -Ibuild-gnulib/import -DTUI=3D1 -Wall -Wpointer-arith -Wno-unused -Wunus= ed-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -W= unused-but-set-parameter -Wunused-but-set-variable=20 -Wno-sign-compare -Wno-narrowing -Wno-error=3Dmaybe-uninitialized -Werror -= c -o regcache.o -MT regcache.o -MMD -MP -MF ./.deps/regcache.Tpo ../../gdb/= regcache.c In file included from ../../gdb/common/common-defs.h:79:0, from ../../gdb/defs.h:28, from ../../gdb/regcache.c:20: ../../gdb/regcache.c: In member function =E2=80=98register_status regcache:= :xfer_part(int, int, int, void*, const void*, bool)=E2=80=99: ../../gdb/regcache.c:935:24: error: the address of =E2=80=98ssize_t read(in= t, void*, size_t)=E2=80=99 will never be NULL [-Werror=3Daddress] gdb_assert (read !=3D NULL); ^ ../../gdb/common/gdb_assert.h:34:13: note: in definition of macro =E2=80=98= gdb_assert=E2=80=99 ((void) ((expr) ? 0 : = \ ^~~~ cc1plus: all warnings being treated as errors IIUC this gdb_assert () is no longer needed: diff --git a/gdb/regcache.c b/gdb/regcache.c index 555db578b6..603d2f211c 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -932,7 +932,6 @@ regcache::xfer_part (int regnum, int offset, int len, v= oid *in, { enum register_status status; - gdb_assert (read !=3D NULL); if (is_raw) status =3D raw_read (regnum, reg); else Dmitry