From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2766 invoked by alias); 10 Sep 2014 07:44:24 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 2716 invoked by uid 89); 10 Sep 2014 07:44:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Sep 2014 07:44:21 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id D18BBC3AD32CC; Wed, 10 Sep 2014 08:44:16 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Sep 2014 08:44:17 +0100 Received: from LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9]) by LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9%17]) with mapi id 14.03.0195.001; Wed, 10 Sep 2014 08:44:17 +0100 From: Matthew Fortune To: Paul Burton , James Hogan CC: "Maciej W. Rozycki" , "gdb@sourceware.org" Subject: RE: Adding MIPS registers (was Re: [PATCH v2] Reset errno before PTRACE_PEEKUSER for MIPS DSP_CONTROL) Date: Wed, 10 Sep 2014 07:44:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B0235320F07F4F@LEMAIL01.le.imgtec.org> References: <1409608120-23991-1-git-send-email-james.hogan@imgtec.com> <20140903125111.GF12084@jhogan-linux.le.imgtec.org> <540F2ECD.5080604@imgtec.com> <20140909203922.GA27832@jhogan-linux.le.imgtec.org> <20140910064706.GS17248@pburton-laptop> In-Reply-To: <20140910064706.GS17248@pburton-laptop> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00037.txt.bz2 DQo+IE9uIFR1ZSwgU2VwIDA5LCAyMDE0IGF0IDA5OjM5OjIyUE0gKzAxMDAs IEphbWVzIEhvZ2FuIHdyb3RlOg0KPiA+ID4gd2l0aCB0aGUgVUZSDQo+ID4g PiBmZWF0dXJlLCBzbyB0aGUgcmVnaXN0ZXIgc2V0IHByZXNlbnRlZCB3aWxs IGhhdmUgdG8gY2hhbmdlIGR5bmFtaWNhbGx5LA0KPiA+ID4gYWNjb3JkaW5n IHRvIHRoYXQgc2V0dGluZyBldmVuIGZvciBMaW51eCB0YXJnZXRzLg0KPiA+ DQo+ID4gSSBoYXZlIGEgZmVlbGluZyB0aGF0IFVGUiBpcyBjdXJyZW50bHkg dW5saWtlbHkgdG8gYmUgZW5hYmxlZCBpbiBMaW51eCwNCj4gPiBkdWUgdG8g c3VidGxldGllcyB3aXRoIG1vZGUgc3dpdGNoZXMgaW4gbXVsdGktdGhyZWFk ZWQgcHJvY2Vzc2VzDQo+ID4gcmVxdWlyaW5nIGtlcm5lbCBzdXBwb3J0LiBN YXR0aGV3IG9yIFBhdWwgKG9uIENDKSBjYW4gcHJvYmFibHkgY29uZmlybQ0K PiA+IHRoYXQuDQo+IA0KPiBDb3JyZWN0LCBVRlIgKGFsb25nIHdpdGggVUZF KSBpcyBjdXJyZW50bHkgbm90IGVuYWJsZWQgYnkgTGludXgsIGFuZCBJJ20N Cj4gbm90IGF3YXJlIG9mIGFueSBuZWVkIHRvIGRlYWwgd2l0aCB0aGUgcGFp biBpbnZvbHZlZCBpbiBlbmFibGluZyBpdC4gVGhlcmUNCj4gaXMgYSBuZWVk IHRvIHN3aXRjaCBtb2RlIGFjcm9zcyBhIHdob2xlIHByb2Nlc3MsIHdoaWNo IHdpbGwgbmVlZCB0byBiZSBtZXQNCj4gaW4gc29tZSBvdGhlciB3YXkgKHRo ZSBwcmN0bHMgaW4gbXkgaW50ZXJuYWwgYnJhbmNoLCBhbmQgaG9wZWZ1bGx5 IHRoZQ0KPiBzYW1lIG9uY2UgdXBzdHJlYW0pLg0KDQpXZSBhcmUgcXVpdGUg YSBsb25nIHdheSBvZmYgdG9waWMgZnJvbSB0aGUgb3JpZ2luYWwgcG9zdCBi dXQgYWxsIHRoaXMgaXMNCmltcG9ydGFudCBmb3IgdGhlIGJ1bGsgb2YgSmFt ZXMnIGZ1cnRoZXIgcGF0Y2hlcy4uLg0KDQpUaGUgTzMyIEZSMC9GUjEgQUJJ IGRvY3VtZW50YXRpb24gaW5jbHVkZXMgYmFzaWMgZGV0YWlscyBvZiB0aGUg bmV3IEZSRQ0KaGFyZHdhcmUgbW9kZSBhbmQgdGhlIGNvcnJlc3BvbmRpbmcg bmV3IEFCSSBleHRlbnNpb24gRlA2NEE6DQoNCmh0dHBzOi8vZG16LXBvcnRh bC5taXBzLmNvbS93aWtpL01JUFNfTzMyX0FCSV8tX0ZSMF9hbmRfRlIxX0lu dGVybGlua2luZyM3Ll9EZWZpbmluZ19PMzJfRlA2NEENCg0KQSBmb3JtYWwg UFJBIGRvY3VtZW50IHdpdGggRlJFIGRlc2NyaWJlZCBpcyBkdWUgd2l0aGlu IGEgd2VlayBvciBzby4NCg0KSXQgYWxzbyBzaG93cyBob3cgdGhlIHByb2dy YW0gbG9hZGVyIGlzIGV4cGVjdGVkIHRvIGJlaGF2ZToNCg0KaHR0cHM6Ly9k bXotcG9ydGFsLm1pcHMuY29tL3dpa2kvTUlQU19PMzJfQUJJXy1fRlIwX2Fu ZF9GUjFfSW50ZXJsaW5raW5nIzEwLjQuX1Byb2dyYW1fbG9hZGVyDQoNCkFu ZCBob3cgbW9kZSBzd2l0Y2hpbmcgaXMgdG8gYmUgcGVyZm9ybWVkOg0KDQpo dHRwczovL2Rtei1wb3J0YWwubWlwcy5jb20vd2lraS9NSVBTX08zMl9BQklf LV9GUjBfYW5kX0ZSMV9JbnRlcmxpbmtpbmcjMTAuNS4yLl9TZXR0aW5nX3Ro ZV9GUFVfbW9kZQ0KDQpJIHdvdWxkIGxpa2UgdG8gcHJvcG9zZSB0aGF0IEdE QiBpcyBub3QgYWJsZSB0byBjaGFuZ2UgdGhlIEZSIG9yIEZSRSBiaXRzDQpk aXJlY3RseS4gVGhlc2UgYml0cyBoYXZlIHRvIGJlIGhhbmRsZWQgd2l0aCBl eHRyZW1lIGNhdXRpb24gYW5kIHRoZXJlIGlzDQpubyBwbGFuIHRvIHN1cHBv cnQgdXNlcnMgY2hhbmdpbmcgdGhlbSBhdCBhcmJpdHJhcnkgcG9pbnRzIGVp dGhlciBvbiBiYXJlDQptZXRhbCBvciB1c2VyLWxhbmQuIFRoZSBpbnRlbnRp b24gaXMgdGhhdCBhIHByb2dyYW0gaXMgcHJvdmlkZWQgd2l0aCBhDQpzdGFi bGUgZW52aXJvbm1lbnQgdG8gcnVuIGluIHdoZXJlIGV2ZXJ5IGxvYWRlZCBm dW5jdGlvbiAoYW5kIHJlZ2lvbiBvZg0KYSBmdW5jdGlvbikgY2FuIGJlIGV4 ZWN1dGVkIGluIHRoZSBjdXJyZW50IG1vZGUuIFdoZW4gYWRkaW5nIG5ldyBj b2RlIGludG8NCmEgcHJvY2VzcyB0aGVuIGEgbmV3IGhhcmR3YXJlIG1vZGUg bWF5IGJlIHJlcXVpcmVkIGJ1dCB0aGUgY2hhbmdlIG9mIG1vZGUNCmlzIHBl cmZvcm1lZCBhdG9taWNhbGx5IGFjcm9zcyBhbGwgdGhyZWFkcyBpbiBhIHBy b2Nlc3MuIEZvciBiYXJlLW1ldGFsDQp0aGVyZSBpcyBhbG1vc3Qgbm8gcmVh c29uIGFueW9uZSB3aWxsIG5lZWQgYSBtb2RlIHN3aXRjaCBzbyB0aGF0IGNh biBiZQ0KZGlzcmVnYXJkZWQgZW50aXJlbHkuDQoNCkknbGwgcmVwbHkgYWJv dXQgcmVnaXN0ZXIgbGF5b3V0cyBzZXBhcmF0ZWx5IGFsdGhvdWdoIHRoYXQg dG9waWMgaXMgbW9zdGx5DQpzdWJqZWN0aXZlLg0KDQpUaGFua3MsDQpNYXR0 aGV3DQo= >From gdb-return-43699-listarch-gdb=sources.redhat.com@sourceware.org Wed Sep 10 10:58:49 2014 Return-Path: Delivered-To: listarch-gdb@sources.redhat.com Received: (qmail 4017 invoked by alias); 10 Sep 2014 10:58:48 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Delivered-To: mailing list gdb@sourceware.org Received: (qmail 4005 invoked by uid 89); 10 Sep 2014 10:58:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Sep 2014 10:58:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAwZPX006737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Sep 2014 06:58:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8AAwX74025243; Wed, 10 Sep 2014 06:58:34 -0400 Message-ID: <54102ED8.7060307@redhat.com> Date: Wed, 10 Sep 2014 10:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Joel Brobecker , Gary Benson CC: gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> In-Reply-To: <20140814125224.GF4924@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00038.txt.bz2 Content-length: 2256 On 08/14/2014 01:52 PM, Joel Brobecker wrote: >> 1. With paths and with the date-and-author header: >> >> gdb/ >> 2014-07-30 Gary Benson >> >> * btrace.c: Include defs.h. >> * common/ptid.c: Include defs.h or server.h as appropriate. >> * nat/mips-linux-watch.c: Likewise. >> >> 2. With date-and-author headers but no paths: >> >> 2014-08-04 Tom Tromey >> >> * gdb.base/sss-bp-on-user-bp-2.exp: Match "to_resume", not >> "target_resume". >> >> 3. With paths but no date-and-author headers: >> >> gdb/ChangeLog: >> >> * amd64-windows-tdep.c (amd64_windows_frame_decode_insns): >> Add debug trace. >> >> 4. With no preamble at all: >> >> * chew.c (print_stack_level, main): Cast result of pointer >> difference to match format string. >> >> What are people's preferences here? My preference is #1, but I could >> live with #3. If we come to some kind of concensus on this I'll >> update the wiki to reflect this. > > #3, since date and author are often redundant with the commit's > author. And even if not in the same, it's in the ChangeLog entry > that should be checked in as part of the commit. Also, I feel > like having those in the CL is an extra source of potential > issue (eg: if forgot to update the date), and revision logs > cannot be fixed once the commit has been pushed, whereas dates > in ChangeLog entries can. Because on git, email == patch == commit, I've now noticed that we're now actually losing author info in patch _submissions_ because of this rule and the rule that we don't post the ChangeLog diff. E.g., I suspect this patch: https://sourceware.org/ml/gdb-patches/2014-08/msg00650.html will end up with both Gary's and Tom's name in the ChangeLog, but that's really just a guess. This makes it impossible for someone else to push the patch other than the submitter, because not all the info is there. It's a bigger issue even if someone posts a patch written or co-written by someone that might not have copyright assignment in place. I think author info must be explicit in patch submissions somehow. Thanks, Pedro Alves