From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Pedro Alves" <pedro@codesourcery.com>, <gdb@sourceware.org>
Subject: RE: Missing new inferior notification for core files
Date: Wed, 06 May 2009 13:45:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA0762F552@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <200905052139.07139.pedro@codesourcery.com>
> -----Original Message-----
> From: gdb-owner@sourceware.org
> [mailto:gdb-owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Tuesday, May 05, 2009 4:39 PM
> To: gdb@sourceware.org
> Cc: Marc Khouzam
> Subject: Re: Missing new inferior notification for core files
>
> On Tuesday 05 May 2009 21:29:01, Pedro Alves wrote:
> > A Tuesday 05 May 2009 21:15:23, Marc Khouzam wrote:
>
> > > Maybe this is a simple fix that can get in before branch
> time for 7.0?
> >
> > Patch and/or a bugzilla PR is welcome.
My apologies about not providing such a simple fix myself.
To be honnest, I hadn't realized it would be soooo easy.
> On second thought, this way is simpler. Try this. I'm giving it a
> testsuite spin. We'll handle the inferior pid change later.
Of course, this worked great.
Thanks!
>
> --
> Pedro Alves
>
> ---
> gdb/inferior.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: src/gdb/inferior.c
> ===================================================================
> --- src.orig/gdb/inferior.c 2009-05-05 21:34:08.000000000 +0100
> +++ src/gdb/inferior.c 2009-05-05 21:34:34.000000000 +0100
> @@ -84,6 +84,8 @@ add_inferior_silent (int pid)
> inf->next = inferior_list;
> inferior_list = inf;
>
> + observer_notify_new_inferior (pid);
> +
> return inf;
> }
>
> @@ -92,8 +94,6 @@ add_inferior (int pid)
> {
> struct inferior *inf = add_inferior_silent (pid);
>
> - observer_notify_new_inferior (pid);
> -
> if (print_inferior_events)
> printf_unfiltered (_("[New inferior %d]\n"), pid);
>
>
next prev parent reply other threads:[~2009-05-06 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 20:15 Marc Khouzam
2009-05-05 20:28 ` Pedro Alves
2009-05-05 20:38 ` Pedro Alves
2009-05-06 13:45 ` Marc Khouzam [this message]
2009-05-06 17:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA0762F552@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=gdb@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox