From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: <gdb@sourceware.org>
Subject: RE: Watchpoint conditions broken?
Date: Thu, 10 Apr 2008 14:17:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BCCF@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <uy77magfq.fsf@gnu.org>
> Hardware watchpoints _are_ supposed to trigger, but once they do, GDB
> should see that the condition is false, and not announce the
> watchpoint.
That is what I needed to know. Thanks.
I believe the problem is in update_watchpoint().
The below shows a fix that worked for me.
Funny thing is that this fix is the original way the code
was posted, as part of the patch about multiple locations
for hardware breakpoints.
http://sourceware.org/ml/gdb-patches/2007-12/msg00008.html
Does it make sense?
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.307
diff -u -r1.307 breakpoint.c
--- gdb/breakpoint.c 14 Mar 2008 18:57:43 -0000 1.307
+++ gdb/breakpoint.c 10 Apr 2008 02:57:41 -0000
@@ -986,7 +986,7 @@
value_free (v);
}
- if (reparse && b->cond_string != NULL)
+ if (b->cond_string != NULL)
{
char *s = b->cond_string;
if (b->loc->cond)
==
Marc Khouzam
next prev parent reply other threads:[~2008-04-10 3:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 3:07 Marc Khouzam
2008-04-10 9:16 ` Eli Zaretskii
2008-04-10 14:17 ` Marc Khouzam [this message]
2008-04-10 17:41 ` Vladimir Prus
2008-05-01 18:10 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA04E1BCCF@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox