From: Tom de Vries via Gdb <gdb@sourceware.org>
To: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Fixing commit dates before pushing
Date: Tue, 12 May 2026 10:19:26 +0200 [thread overview]
Message-ID: <6789f4cc-cc39-4061-8079-195d5ef5a362@suse.de> (raw)
Hi,
back in 2014, a requirement was added to the contribution checklist:
fixing commit dates (
https://sourceware.org/gdb/wiki/ContributionChecklist#Fixing_commit_dates ).
The related discussion is here (
https://inbox.sourceware.org/gdb/20140814083231.GA6283@blade.nx/T/#u ).
Looking at recent commits, this is done by a few people, but not everybody.
[ FWIW, I'm using a push script (see below) that takes care of this for
me. ]
If not too many people actually do this, and nobody's complaining about
it, should we drop the requirement?
Otherwise, perhaps we could invest in some pre-commit infrastructure to
enforce/implement this more easily.
Thanks,
- Tom
$ cat ../push.sh
#!/bin/sh
set -e
branch=$(git branch \
| grep "\*" \
| awk '{print $2}')
echo "REMINDER: Did you apply the Approved-By/Tested-By/Reviewed-By tags?"
echo
echo "Push branch $branch upstream?"
echo "Press ^C to cancel"
read
git fetch -fp origin
git rebase --ignore-date origin/$branch
git push --set-upstream origin $branch:$branch
$
next reply other threads:[~2026-05-12 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:19 Tom de Vries via Gdb [this message]
2026-05-12 11:57 ` Eli Zaretskii via Gdb
2026-05-12 14:58 ` Arsen Arsenović via Gdb
2026-05-12 14:15 ` Simon Marchi via Gdb
2026-05-12 17:46 ` Guinevere Larsen via Gdb
2026-05-14 19:29 ` Tom Tromey
2026-05-15 14:49 ` Andrew Burgess via Gdb
2026-05-26 11:37 ` Tom de Vries via Gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6789f4cc-cc39-4061-8079-195d5ef5a362@suse.de \
--to=gdb@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox