From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uMnGNM7mMmM2zgAAWB0awg (envelope-from ) for ; Tue, 27 Sep 2022 08:04:30 -0400 Received: by simark.ca (Postfix, from userid 112) id D37631E112; Tue, 27 Sep 2022 08:04:30 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ESnE9V24; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 806801E0D3 for ; Tue, 27 Sep 2022 08:04:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 318B6385740B for ; Tue, 27 Sep 2022 12:04:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 318B6385740B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664280270; bh=nFIzMuZCzLelwi08MCrdWrmmfBH8Rc22KZD5tYftgrY=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ESnE9V24qn6mTQDEEIi+bSpSdEyDENh/yIPfoTbe5omcCfWZPWrUz+h9f4aydR+bJ ST5URYlQhvXTbeVePDQRpytFwKseoy/zeJCqlIknKuAJmLz0miiyo6AlmKbqDT1YFQ I/+Tj4OL4ewIrZKC/BxryHGK8ZNrE1dyKw+IvNSg= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D6F6738582B3 for ; Tue, 27 Sep 2022 12:04:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6F6738582B3 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-60-m2xqfK3YPIKGXX-MnHhX7w-1; Tue, 27 Sep 2022 08:04:01 -0400 X-MC-Unique: m2xqfK3YPIKGXX-MnHhX7w-1 Received: by mail-wm1-f71.google.com with SMTP id h187-20020a1c21c4000000b003b51369ff1bso6520187wmh.3 for ; Tue, 27 Sep 2022 05:04:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=nFIzMuZCzLelwi08MCrdWrmmfBH8Rc22KZD5tYftgrY=; b=p9vGH1OiPxHlA30bL8mLSjc60Tu9apqrs/xx3FESZ7lbRSKrE8WaIt4qOh1AVh+PGU itXbMLklF0/K2aJzOJ9ML0xhg1sfE70E8PLh98akKiY4H8gyn8NZ2dYDb5yclQ8wQuhe PQO8nTYAR61azLGrZjKDgSwZyCNwemFnCZs3tbfyrxCYEQ5xDCqiIC5rvZDVxEpK92Ux jF/f6ibdX4GlD1XDkNwAUEGNZSe6JdZ6zUz5x7ore7dWVbYNvFB546RqUL5th9xnJpNf sBKcE3KyDHu1dvZIfHVd7qMQpQfmFuWL36Gch03RPh5uDrpxGt8SXx2pFjCNPXedBUkR FtwA== X-Gm-Message-State: ACrzQf0YXaHSEKqyRS82mflSaKIu1XhjkfYBIGGme5WX1PAK+iFAZk7k E1BPL8C6Jq4ZREvCVplbK4zCrTKb5V+WLJWNQ0/4/uQPcOm6NydYWbh40ptEhiq5zaE/BTyc4g5 Z4blBrZDfgXI= X-Received: by 2002:adf:f58a:0:b0:22c:be20:24e8 with SMTP id f10-20020adff58a000000b0022cbe2024e8mr1599626wro.245.1664280239909; Tue, 27 Sep 2022 05:03:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5umWfIJhFV2evWI+ZN+8pUpga5rOdCeLKSTZKL2E99r0fAao5EQNjXXQADHCMuf0D9l0ojLA== X-Received: by 2002:adf:f58a:0:b0:22c:be20:24e8 with SMTP id f10-20020adff58a000000b0022cbe2024e8mr1599600wro.245.1664280239454; Tue, 27 Sep 2022 05:03:59 -0700 (PDT) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id y3-20020a5d4ac3000000b0022ac672654dsm1769357wrs.58.2022.09.27.05.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 05:03:59 -0700 (PDT) Message-ID: <65be7ed9-7e0e-fd85-96ed-28bfaa442bca@redhat.com> Date: Tue, 27 Sep 2022 14:03:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: Proposal: Add review tags to patch review workflow. To: Simon Marchi , John Baldwin , gdb@sourceware.org References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> <4c321d90-ca45-c3dd-27dc-cc8c74b6e999@FreeBSD.org> <5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com> <8b2913f0-fd8c-5b48-cab3-f87b581171e1@simark.ca> In-Reply-To: <8b2913f0-fd8c-5b48-cab3-f87b581171e1@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb Reply-To: Bruno Larsen Errors-To: gdb-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 27/09/2022 14:02, Simon Marchi wrote: > >>> It also wasn't clear to me if the intention was for the commits to >>> be amended with the annotations?  (I don't think it was explicitly >>> stated in the original mail, and I'm not sure if it was an implicit >>> assumption?) >> No, I didn't intend on amending previous commits. The main problem this change intends to solve is fixing ambiguity, and the pushed patches don't have that issue anymore. Thanking a reviewer is just one more positive side (IMHO) going forward. > Err, just to be clear, we won't amend existing commits in master > obviously (can't rewrite history) but future commits in master would > contain those tags. This means that if you give me a Reviewed-By, I > amend my local commit patch to include that trailer before pushing. Yes, thank you for clarifying what I meant! Cheers, Bruno > Simon >