From: Dmitry Antipov <dantipov@nvidia.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: GDB Development <gdb@sourceware.org>, Yao Qi <yao.qi@linaro.org>
Subject: Re: aarch64-tdep.c:379: internal-error: CORE_ADDR aarch64_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, aarch64_prologue_cache*, {anonymous}::abstract_instruction_reader&): Assertion `inst.operands[0].qualifier == AARCH64_OPND_QLF_S_D' failed
Date: Tue, 03 Apr 2018 10:01:00 -0000 [thread overview]
Message-ID: <64710bf6-a3e7-cb32-94df-0337f09fd944@nvidia.com> (raw)
In-Reply-To: <72908568cb161628681345981f5c0b87@polymtl.ca>
On 04/03/2018 04:35 AM, Simon Marchi wrote:
> So it looks like the GDB code assumes that no-one would ever save the whole registers, because it is not necessary. GDB should not use gdb_assert and crash on bad input. I don't know what it should
> do instead in that specific case, that's the part that takes more time to think about :).
I think that "ABI violation" is not always a synonym for "bad input" :-), and we definitely don't want the debugger to crash on some handwritten
inline assembler trick, for example. BTW, LLVM project debugger lldb seems uses more relaxed approach and allows STP with FP quadword operands in
function prologues, see https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp.
Dmitry
next prev parent reply other threads:[~2018-04-03 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aa495229-c377-8a47-5fb3-7040c16adbda@nvidia.com>
2018-04-03 1:35 ` Simon Marchi
2018-04-03 10:01 ` Dmitry Antipov [this message]
2018-04-03 12:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64710bf6-a3e7-cb32-94df-0337f09fd944@nvidia.com \
--to=dantipov@nvidia.com \
--cc=gdb@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=yao.qi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox