Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: dje@transmeta.com
Cc: gdb@sources.redhat.com
Subject: Re: STOPPED_BY_WATCHPOINT peculiarity
Date: Fri, 05 Apr 2002 03:22:00 -0000	[thread overview]
Message-ID: <6137-Fri05Apr2002141806+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <200204022154.NAA10074@casey.transmeta.com> (message from Doug Evans on Tue, 2 Apr 2002 13:54:47 -0800)

> Date: Tue, 2 Apr 2002 13:54:47 -0800
> From: Doug Evans <dje@transmeta.com>
> 
>     /* It may be possible to simply continue after a watchpoint.  */
>     if (HAVE_CONTINUABLE_WATCHPOINT)
>       STOPPED_BY_WATCHPOINT (ecs->ws);
> 
> STOPPED_BY_WATCHPOINT is a predicate.
> Therefore at first glance this code is pointless.

Who said predicates cannot have side effects?

Anyway, this code is there in GDB for as long as I can remember.
Presumably, it's a survivor from the days when watchpoints were added
to GDB for Sparclet or some such.

I don't mind the extra comment, though.  My only request is to change
the wording of the comment so that the kind of use in i386-nat.c is an
example of how it could be used, not the original purpose of this code
(which is unknown to me).  IMHO, the comment should serve as a warning
against the temptation of removing it, or otherwise rewriting it in
ways that could break ecisting usage.

Thanks.


  parent reply	other threads:[~2002-04-05 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-02 13:55 Doug Evans
2002-04-02 14:03 ` Daniel Jacobowitz
2002-04-02 14:20   ` Daniel Jacobowitz
2002-04-11 14:15     ` Michael Snyder
2002-04-05  3:22 ` Eli Zaretskii [this message]
2002-04-05  8:46   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6137-Fri05Apr2002141806+0300-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=dje@transmeta.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox