From: jtc@redback.com (J.T. Conklin)
To: gdb@sourceware.cygnus.com
Subject: savestring()
Date: Wed, 21 Mar 2001 15:59:00 -0000 [thread overview]
Message-ID: <5m1ysgopq8.fsf@jtc.redback.com> (raw)
Lint complaints about signed/unsigned conversions in the typical use
of savestring:
x->foo = savestring(bar, strlen(bar));
Is there any reason why we shouldn't change the type of savestring's
(likewise msavestring) second argument from int to size_t?
Also, since the above is the same as:
x->foo = xstrdup(bar);
Is there any reason why we shouldn't change it? It's a bit odd that
half the code uses savestring() and the other half uses xstrdup().
--jtc
--
J.T. Conklin
RedBack Networks
next reply other threads:[~2001-03-21 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-21 15:59 J.T. Conklin [this message]
2001-03-21 15:59 ` savestring() Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5m1ysgopq8.fsf@jtc.redback.com \
--to=jtc@redback.com \
--cc=gdb@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox