From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25731 invoked by alias); 9 Mar 2019 00:18:45 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 23815 invoked by uid 89); 9 Mar 2019 00:18:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,LIKELY_SPAM_SUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*c:PHrt, H*x:5.0, H*UA:6.1, H*x:Windows X-HELO: sonic310-12.consmr.mail.ir2.yahoo.com Received: from sonic310-12.consmr.mail.ir2.yahoo.com (HELO sonic310-12.consmr.mail.ir2.yahoo.com) (77.238.177.33) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Mar 2019 00:18:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1552090717; bh=njlbjHkUJIa9JztLaD1bsqYBcnAtpTmR+Q8/uVMTCHI=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=ZVIbHBHGQWi7lK0HZmsUKVNl2Z7yrvltfhBT215vGIM99k9xFBZR1s9V9cmKao1a2VB7mIOok045rSsgnsQwikm/h2YSdtQDS8d4oGs/X7xNWok/ouSKTAbK3iCinW4Hmu3YPOgCuioEppsUA/Lu2tWJM6jyT7UPkZ5uWxCPv19N1vRLZqvla45n0U3XP946nPsYfGiO8mumZ/kJg2XUFBTV4yWaWWsBnEazhlhXkeL70E/SxDKFdJAzK6aH3q/ZbqieBvfFPZFwoYEuFOrtKFdWhT230B5jJ2YPccQbkP/tMjwsB9NGWeYD+nV1/smhYrI/dgJE797m0jKMi744mA== Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sat, 9 Mar 2019 00:18:37 +0000 Date: Sat, 09 Mar 2019 00:18:00 -0000 From: "Hannes Domani via gdb" Reply-To: Hannes Domani To: GDB Development Message-ID: <598470969.3054035.1552090704729@mail.yahoo.com> In-Reply-To: <605876742.3053854.1552089304851@mail.yahoo.com> References: <183519794.10360727.1551304006549.ref@mail.yahoo.com> <183519794.10360727.1551304006549@mail.yahoo.com> <87h8copz0d.fsf@tromey.com> <1428427467.10799860.1551353565332@mail.yahoo.com> <87lg1yh2gx.fsf@tromey.com> <1682009983.12256919.1551466302655@mail.yahoo.com> <87mum5f4uj.fsf@tromey.com> <605876742.3053854.1552089304851@mail.yahoo.com> Subject: Fw: question about expand_symtabs_matching() MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3054034_655375985.1552090704729" X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00016.txt.bz2 ------=_Part_3054034_655375985.1552090704729 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 1153 Am Freitag, 8. M=C3=A4rz 2019, 22:13:52 MEZ hat Tom Tromey = Folgendes geschrieben: > >>>>> "Hannes" =3D=3D Hannes Domani via gdb writes: >=20 > Hannes> For the case of 'b some_function', with the application I'm testi= ng: > Hannes> - startup time with the call of cp_canonicalize_string_no_typedef= s(): 1m 25s > Hannes> - startup time without this call: 27s >=20 > Wow. >=20 > Hannes> In my personal build I've changed this: > Hannes> - only call cp_canonicalize_string_no_typedefs() if it's not a si= mple function > Hannes>=C2=A0=C2=A0 name (like 'function_name' or 'Class::member_function= ') > Hannes> - only call expand_symtabs_matching() if the lookup_name doesn't = contain a '.' > > Hannes> I admit that I don't fully understand what could break with thes= e changes, > Hannes> but the speedup makes it worth for me right now. >=20 > Could you send the diff? Both are attached. As said before, the first improves the startup time (with 1 pending functio= n breakpoint) from 1m 25s to 27s. And the second improves it (with 1 pending source:line breakpoint) from 27s= to 13s. Regards Hannes Domani ------=_Part_3054034_655375985.1552090704729 Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="=?UTF-8?b?MDAwMS1Eb24tdC1leHBhbmQtdHlwZWRlZnMtZm9yLWZ1bmN0aW9ucy13aXRob3V0LWFyZ3VtZW50LnBhdGNo?=" Content-ID: <78381e08-c1b7-c2b9-a9f8-5341d6779336@yahoo.com> Content-length: 2074 RnJvbSAyOTAyZjhlMjhiNWQ4ZTNjMmJmNDAxMGM4YmY0OTVhZTRiYzk4ZmYz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5uZXMgRG9tYW5p IDxzc2Jzc2FAeWFob28uZGU+CkRhdGU6IEZyaSwgMSBNYXIgMjAxOSAxNDow NToxNyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBEb24ndCBleHBhbmQg dHlwZWRlZnMgZm9yIGZ1bmN0aW9ucyB3aXRob3V0IGFyZ3VtZW50cy4KCi0t LQogZ2RiL2xpbmVzcGVjLmMgfCAyMSArKysrKysrKysrKysrKysrKysrKy0K IDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvZ2RiL2xpbmVzcGVjLmMgYi9nZGIvbGluZXNw ZWMuYwppbmRleCAwZjJmY2ZkZmYwLi5iMDFhZmFkZDkxIDEwMDY0NAotLS0g YS9nZGIvbGluZXNwZWMuYworKysgYi9nZGIvbGluZXNwZWMuYwpAQCAtMzg5 OSw2ICszODk5LDIzIEBAIGZpbmRfZnVuY3Rpb25fc3ltYm9scyAoc3RydWN0 IGxpbmVzcGVjX3N0YXRlICpzdGF0ZSwKIAkJCQkgICZpbmZvLCBzdGF0ZS0+ c2VhcmNoX3BzcGFjZSk7CiB9CiAKK3N0YXRpYyBib29sCitpc19zaW1wbGVf bmFtZSAoY29uc3QgY2hhciAqbmFtZSkKK3sKKyAgZG8KKyAgICB7CisgICAg ICBpZiAobmFtZVswXSA9PSAnOicgJiYgbmFtZVsxXSA9PSAnOicpCisJbmFt ZSArPSAyOworICAgICAgaWYgKCpuYW1lID09ICc6JykKKwlicmVhazsKKyAg ICAgIHdoaWxlICgoKm5hbWUgPj0gJ0EnICYmICpuYW1lIDw9ICdaJykgfHwg KCpuYW1lID49ICdhJyAmJiAqbmFtZSA8PSAneicpCisJICAgICB8fCAoKm5h bWUgPj0gJzAnICYmICpuYW1lIDw9ICc5JykgfHwgKm5hbWUgPT0gJ18nKQor CW5hbWUrKzsKKyAgICB9CisgIHdoaWxlIChuYW1lWzBdID09ICc6JyAmJiBu YW1lWzFdID09ICc6Jyk7CisgIHJldHVybiAqbmFtZSA9PSAnXDAnOworfQor CiAvKiBGaW5kIGFsbCBzeW1ib2xzIG5hbWVkIE5BTUUgaW4gRklMRV9TWU1U QUJTLCByZXR1cm5pbmcgZGVidWcgc3ltYm9scwogICAgaW4gU1lNQk9MUyBh bmQgbWluaW1hbCBzeW1ib2xzIGluIE1JTlNZTVMuICAqLwogCkBAIC0zOTEw LDcgKzM5MjcsOSBAQCBmaW5kX2xpbmVzcGVjX3N5bWJvbHMgKHN0cnVjdCBs aW5lc3BlY19zdGF0ZSAqc3RhdGUsCiAJCSAgICAgICBzdGQ6OnZlY3RvciA8 YmxvY2tfc3ltYm9sPiAqc3ltYm9scywKIAkJICAgICAgIHN0ZDo6dmVjdG9y PGJvdW5kX21pbmltYWxfc3ltYm9sPiAqbWluc3ltcykKIHsKLSAgc3RkOjpz dHJpbmcgY2Fub24gPSBjcF9jYW5vbmljYWxpemVfc3RyaW5nX25vX3R5cGVk ZWZzIChsb29rdXBfbmFtZSk7CisgIHN0ZDo6c3RyaW5nIGNhbm9uOworICBp ZiAoIWlzX3NpbXBsZV9uYW1lIChsb29rdXBfbmFtZSkpCisgICAgY2Fub24g PSBjcF9jYW5vbmljYWxpemVfc3RyaW5nX25vX3R5cGVkZWZzIChsb29rdXBf bmFtZSk7CiAgIGlmICghY2Fub24uZW1wdHkgKCkpCiAgICAgbG9va3VwX25h bWUgPSBjYW5vbi5jX3N0ciAoKTsKIAotLSAKMi4xNS4xLndpbmRvd3MuMgoK ------=_Part_3054034_655375985.1552090704729 Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="=?UTF-8?b?MDAwMi1Eb24tdC1leHBhbmQtc3ltdGFicy13aGVuLWxvb2tpbmctZm9yLWEtZmlsZW5hbWUucGF0Y2g=?=" Content-ID: <935f706b-7dc0-19bd-5b97-016e4740fa70@yahoo.com> Content-length: 1042 RnJvbSA5ZjFlNGMxMGI5ZTNhNjkxZjY3NGIyZDJhNWM5ZDRhZjMwNWYwYjI2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5uZXMgRG9tYW5p IDxzc2Jzc2FAeWFob28uZGU+CkRhdGU6IEZyaSwgMSBNYXIgMjAxOSAxNDow Nzo0NyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBEb24ndCBleHBhbmQg c3ltdGFicyB3aGVuIGxvb2tpbmcgZm9yIGEgZmlsZW5hbWUuCgotLS0KIGdk Yi9saW5lc3BlYy5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvbGlu ZXNwZWMuYyBiL2dkYi9saW5lc3BlYy5jCmluZGV4IGU5MDJiMTFjOGUuLjBm MmZjZmRmZjAgMTAwNjQ0Ci0tLSBhL2dkYi9saW5lc3BlYy5jCisrKyBiL2dk Yi9saW5lc3BlYy5jCkBAIC0xMTQzLDcgKzExNDMsOCBAQCBpdGVyYXRlX292 ZXJfYWxsX21hdGNoaW5nX3N5bXRhYnMKIAogICAgIGZvciAob2JqZmlsZSAq b2JqZmlsZSA6IGN1cnJlbnRfcHJvZ3JhbV9zcGFjZS0+b2JqZmlsZXMgKCkp CiAgICAgICB7Ci0JaWYgKG9iamZpbGUtPnNmKQorCWlmIChvYmpmaWxlLT5z ZgorCSAgICAmJiBsb29rdXBfbmFtZS5uYW1lICgpLmZpbmQgKCcuJykgPT0g c3RkOjpzdHJpbmc6Om5wb3MpCiAJICBvYmpmaWxlLT5zZi0+cWYtPmV4cGFu ZF9zeW10YWJzX21hdGNoaW5nIChvYmpmaWxlLAogCQkJCQkJICAgIE5VTEws CiAJCQkJCQkgICAgbG9va3VwX25hbWUsCi0tIAoyLjE1LjEud2luZG93cy4y Cgo= ------=_Part_3054034_655375985.1552090704729--