From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eFG8C+WbhmdpAA8AWB0awg (envelope-from ) for ; Tue, 14 Jan 2025 12:16:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=x7rPIe+H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2BCEF1E100; Tue, 14 Jan 2025 12:16:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D75C91E05C for ; Tue, 14 Jan 2025 12:16:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7E0243856264 for ; Tue, 14 Jan 2025 17:16:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E0243856264 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1736874980; bh=Be4GzJk/wsD6HKDtN87JK0kJO4yhKr5UqkHJ5J6D1F4=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=x7rPIe+HA7CkD6bqlP9P8gDKGuez6Q4x/jwNjdy7/YcQ07XpxX/HXly+fHW9mHyKl GD3b52jMLsO2f2eXNT/EdO+VSFzIR9r1CaW8/ryHfdlDJ2gCQqFeXSWfI6bZodN+wY hhB1N4fsPe3HiXcqpggnNG37nsYYv960TWtSuJ5g= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 01606385B830 for ; Tue, 14 Jan 2025 17:15:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01606385B830 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01606385B830 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736874924; cv=none; b=u2Qhz5Tc8xLSzqr3JLn5atj2PM/8NcaglMOUd6CVao4FLS8CL9KE5baYxfscT4xUkMzHd7E5BdXLkch/dSonuqRYgfa1pN1MBm5GIyeNVGudWLdZxRy83lXw0zFRFlDtvBiVtLVfCZaC1BnRgyumgmfZkME2769YW/PEPlCJcjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736874924; c=relaxed/simple; bh=DiRC1rglO66OuYfagdEwQjoFekRiJBzhig/5siXkg9c=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=mWrDXJcWqBcMpsRY6fQr0i94EAa+ne3IRuQ8K75GkyR4xSTxwCGfAQmu65KkJVdTthXuF1PYpb9YgehBQqdrZ8z5Sryv2/Jfmnq5a0nRllpifny2ECkTBi5cb7RQcGMQozw2mNpOTF07jCrqkfV1hlbm6k3eGovBXgQZH96mqtc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01606385B830 Received: by simark.ca (Postfix, from userid 112) id A5FE11E100; Tue, 14 Jan 2025 12:15:23 -0500 (EST) Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F1DDD1E05C; Tue, 14 Jan 2025 12:15:22 -0500 (EST) Message-ID: <593cf91e-b6e6-42ef-9bcf-3fcde104f6d5@simark.ca> Date: Tue, 14 Jan 2025 12:15:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: automated coding style tool To: Tom Tromey , "Aktemur, Tankut Baris via Gdb" Cc: "Aktemur, Tankut Baris" References: <86538dac-6c3a-4b9e-9de9-3906e645fa4d@redhat.com> <87y16vwbzl.fsf@tromey.com> <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> Content-Language: en-US In-Reply-To: <87tta1qq1i.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb Reply-To: Simon Marchi Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 2025-01-14 12:11, Tom Tromey wrote: > I don't recall why I commented this out. Anyway clang-format doesn't > come very close to GNU style. I'd be ok with ignoring most of the > little differences (i.e., I don't care about goto label placement), but > the bin packing output is just super ugly some of the time. > > Tom I don't know how often those ugly outputs happen, but it is possible to disable clang-format locally, like this: https://github.com/efficios/babeltrace/blob/5105ea10985ef0512878ff3f9bc8e1092735e75c/src/cpp-common/bt2/field-path.hpp#L106-L114 So if it's a relatively rare occurence that the output is atrociously bad enough to make your eyes bleed, the benefit of the tool is still there. Simon