From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9470 invoked by alias); 3 Nov 2009 22:03:54 -0000 Received: (qmail 9461 invoked by uid 22791); 3 Nov 2009 22:03:54 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-out3.apple.com (HELO mail-out3.apple.com) (17.254.13.22) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 22:03:48 +0000 Received: from relay13.apple.com (relay13.apple.com [17.128.113.29]) by mail-out3.apple.com (Postfix) with ESMTP id AD630785B9F6; Tue, 3 Nov 2009 14:03:46 -0800 (PST) Received: from gdbrulez.apple.com (gdbrulez.apple.com [17.224.14.42]) by relay13.apple.com (Apple SCV relay) with SMTP id 38.CF.16384.2C8A0FA4; Tue, 3 Nov 2009 14:03:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1077) Subject: Re: gdb v7.0 - user defined command's document section - space prefixed end From: Jim Ingham In-Reply-To: <20091103195130.GA19931@caradoc.them.org> Date: Tue, 03 Nov 2009 22:03:00 -0000 Content-Transfer-Encoding: quoted-printable Message-Id: <58750BDB-0AC0-46E0-938D-6DF92EE35186@apple.com> References: <4AE7D19A.70600@googlemail.com> <20091103143305.GN4573@adacore.com> <4AF07D60.2020305@googlemail.com> <20091103194313.GS4573@adacore.com> <20091103195130.GA19931@caradoc.them.org> To: Daniel Jacobowitz , gdb@sourceware.org X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00033.txt.bz2 This patch has my and Vladimir's names on it, presumably Vladimir was porti= ng some of the Apple local changes over to the FSF gdb. But in our version= of gdb we unconditionally strip leading whitespace, and spaces before "end= " don't matter. So sadly I can't help explain the reasoning behind the cha= nge. If this is indeed the right patch, you'll have to bug Vladimir for th= e motivation. Jim On Nov 3, 2009, at 11:51 AM, Daniel Jacobowitz wrote: > On Tue, Nov 03, 2009 at 11:43:13AM -0800, Joel Brobecker wrote: >>> I noticed my scripts didn't work under v7.0 only when I saw this bug in= =20=20 >>> launchpad. I guess I am not the only one who has indented "ends" this w= ay=20 >>> :) >>> https://bugs.launchpad.net/ubuntu/+source/gdb/+bug/461594 >>=20 >> If you could maybe help us a little bit, and track down the author >> of the patch that introduced the change of behavior, and then ask >> him whether the change was intended? >=20 > I believe it was: >=20 > 2009-08-03 Jim Ingham > Vladimir Prus >=20 > Refactor reading of commands >=20 > * defs.h (read_command_lines_1): Declare. > * cli/cli-script.c (read_next_line): Only return string, > do not process. > (process_next_line): New, extracted from read_next_line. > (recurse_read_control_structure): Take a function pointer to the > read function. > (get_command_line) Pass the read_next_line as reader function > into recurse_read_control_structure. > (read_command_lines_1): New, extracted from... > (read_command_lines): ...here. >=20 > --=20 > Daniel Jacobowitz > CodeSourcery