From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13947 invoked by alias); 20 Apr 2016 10:55:23 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 13859 invoked by uid 89); 20 Apr 2016 10:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1880, bark, bless, emailing X-HELO: mailout4.w1.samsung.com Received: from mailout4.w1.samsung.com (HELO mailout4.w1.samsung.com) (210.118.77.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 20 Apr 2016 10:55:12 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O5X001P5IBWO140@mailout4.w1.samsung.com> for gdb@sourceware.org; Wed, 20 Apr 2016 11:55:08 +0100 (BST) Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 3A.BC.05254.B0067175; Wed, 20 Apr 2016 11:55:07 +0100 (BST) Received: from [106.109.9.145] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O5X001P3IBVQZ10@eusync1.samsung.com>; Wed, 20 Apr 2016 11:55:07 +0100 (BST) Subject: Re: [Bug-readline] [PATCH] Enable visibility annotations To: Pedro Alves , Doug Evans References: <94eb2c1232a01a28910530c65c78@google.com> <57171B67.3040204@samsung.com> <57174A3A.80303@redhat.com> <57174FBC.7080909@samsung.com> <5717579B.1020302@redhat.com> Cc: chet.ramey@case.edu, bug-readline@gnu.org, Vyacheslav Barinov , Yury Usishchev , "gdb@sourceware.org" , Jan Kratochvil From: Yury Gribov Message-id: <57176010.6060100@samsung.com> Date: Wed, 20 Apr 2016 10:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <5717579B.1020302@redhat.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-SW-Source: 2016-04/txt/msg00037.txt.bz2 On 04/20/2016 01:19 PM, Pedro Alves wrote: > On 04/20/2016 10:45 AM, Yury Gribov wrote: >> On 04/20/2016 12:22 PM, Pedro Alves wrote: > >>> - Claim that the symbols may no longer be available in a >>> future release. >> >> You mean just email respective package maintainers? > > I was thinking readline's CHANGES / release notes. > > Emailing respective package maintainers / filing bugs with them > doesn't hurt of course. > >> >>> - Give time for packages to clean themselves up, and propose >>> any necessary new replacement APIs. >> >> This would require significant expertise in readline though... > > The alternative is bless the private symbols as > public API forever... Each package owner will know what their > package needs from readline and why they found a need > to (ab)use readline private symbols. I see no way around that. Guess that's what's going to happen (unless some motivated readline maintainer steps in, willing to work with various users on getting rid of leaked symbols). >>> - Optionally, in the release after the next, mark the symbols >>> as deprecated with __attribute__((deprecated)), so packages >>> that abuse private symbols get a build-time warning. >> >> That won't help as these symbols are not present in headers anyway. All >> users have their own private declarations. > > OK. Making it a linker warning instead,using ".gnu.warning.SYMBOL" > sections might still work: > > http://www.airs.com/blog/archives/54 Oh my, this is such a cool feature. I was actually thinking about a "Deprecated" attribute for ELF symbols which static/runtime linker could use to bark. Pushing such thing to Binutils and GCC would take ages though... > Not sure it's a good idea to raise warnings without alternatives > already in place though, thus my "Optionally". > > Thanks, > Pedro Alves > > >