From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100548 invoked by alias); 20 Apr 2016 10:19:26 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 100428 invoked by uid 89); 20 Apr 2016 10:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1400, bless, emailing, claim X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Apr 2016 10:19:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D03F57F36F; Wed, 20 Apr 2016 10:19:13 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3KAJ7X9012947; Wed, 20 Apr 2016 06:19:08 -0400 Subject: Re: [Bug-readline] [PATCH] Enable visibility annotations To: Yury Gribov , Doug Evans References: <94eb2c1232a01a28910530c65c78@google.com> <57171B67.3040204@samsung.com> <57174A3A.80303@redhat.com> <57174FBC.7080909@samsung.com> Cc: chet.ramey@case.edu, bug-readline@gnu.org, Vyacheslav Barinov , Yury Usishchev , "gdb@sourceware.org" , Jan Kratochvil From: Pedro Alves Message-ID: <5717579B.1020302@redhat.com> Date: Wed, 20 Apr 2016 10:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <57174FBC.7080909@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00036.txt.bz2 On 04/20/2016 10:45 AM, Yury Gribov wrote: > On 04/20/2016 12:22 PM, Pedro Alves wrote: >> - Claim that the symbols may no longer be available in a >> future release. > > You mean just email respective package maintainers? I was thinking readline's CHANGES / release notes. Emailing respective package maintainers / filing bugs with them doesn't hurt of course. > >> - Give time for packages to clean themselves up, and propose >> any necessary new replacement APIs. > > This would require significant expertise in readline though... The alternative is bless the private symbols as public API forever... Each package owner will know what their package needs from readline and why they found a need to (ab)use readline private symbols. I see no way around that. > >> - Optionally, in the release after the next, mark the symbols >> as deprecated with __attribute__((deprecated)), so packages >> that abuse private symbols get a build-time warning. > > That won't help as these symbols are not present in headers anyway. All > users have their own private declarations. OK. Making it a linker warning instead,using ".gnu.warning.SYMBOL" sections might still work: http://www.airs.com/blog/archives/54 Not sure it's a good idea to raise warnings without alternatives already in place though, thus my "Optionally". Thanks, Pedro Alves