From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-45026-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 56688 invoked by alias); 23 Mar 2016 12:24:59 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 56675 invoked by uid 89); 23 Mar 2016 12:24:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=bundle, Stay
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 23 Mar 2016 12:24:58 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id EB94F4620B;	Wed, 23 Mar 2016 12:24:56 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2NCOtE3011999;	Wed, 23 Mar 2016 08:24:56 -0400
Subject: Re: JIT debugging (Attach and speed)
To: Yichao Yu <yyc1992@gmail.com>
References: <CAMvDr+TKDYeECiUK7Kz7TGSRF826Vq24z_=CPQXz1vyxmMUm_w@mail.gmail.com> <56F168D7.9050405@redhat.com> <56F16F8F.9050404@redhat.com> <CAMvDr+TRSF16fKnnb9tWD4Xctek31Sdgx2m1ct=UctXL_b9vuA@mail.gmail.com> <56F1759F.3070100@redhat.com> <CAMvDr+QcMrHk6y7hGr1NaijEXK=dH+J0CGJZs6m_Rk2D2oSm-g@mail.gmail.com> <56F17A23.90909@redhat.com> <CAMvDr+ST=4a11-B=ymUQDRdOCZmVUgdfkhFbUDknvjkaGjtGWw@mail.gmail.com>
Cc: gdb@sourceware.org, Paul Pluzhnikov <ppluzhnikov@google.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <56F28B17.4060508@redhat.com>
Date: Wed, 23 Mar 2016 12:24:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CAMvDr+ST=4a11-B=ymUQDRdOCZmVUgdfkhFbUDknvjkaGjtGWw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-03/txt/msg00036.txt.bz2

On 03/23/2016 02:18 AM, Yichao Yu wrote:

>> It'd be very nice if we had a _new_ test that covers your use case,
>> to avoid regressing again.  That likely makes the patch bigger than
>> what we could accept without a copyright assignment though.  If you'd
>> like to pursue that, let me know and I'll send you the forms.
>
> I've got a simple patch that fixes the issue for me and AFAICT all of
> the failing tests are racy and/or failing on this machine before the
> change too. I haven't add test yet since I'm not so sure how to add it
> (I found test for both jit interface and attach but haven't figured
> out how to write a new one yet...).

Excellent, this helps a lot.

I have an idea for the test, so I'll handle it.  Let me bundle
things in a proper patch and post it to gdb-patches.  Stay tuned.

>
> I'm happy to complete copyright related forms necessary.

I'll send this off list.

Thanks,
Pedro Alves