From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-45000-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 43943 invoked by alias); 4 Mar 2016 18:24:24 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 43924 invoked by uid 89); 4 Mar 2016 18:24:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=1156, ptype, www, HContent-Transfer-Encoding:8bit
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Mar 2016 18:24:21 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (Postfix) with ESMTPS id A224FC0A803C;	Fri,  4 Mar 2016 18:24:20 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u24IOJlT027582;	Fri, 4 Mar 2016 13:24:19 -0500
Subject: Re: Printing a 2D array in a C program
To: Jan Kratochvil <jan.kratochvil@redhat.com>, Neven Sajko <nsajko@gmail.com>
References: <CAL+bK4NidroyapZhGvtVVsiCbu4=Hz56mF4_oU3iXM-rvqY_xw@mail.gmail.com> <20160304144231.GA7767@host1.jankratochvil.net> <CAL+bK4MV9ZLkon2PONYRpF0506P8zE3=Ukm0F1zpVDHd2HpAtw@mail.gmail.com> <20160304174859.GA15741@host1.jankratochvil.net>
Cc: gdb@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <56D9D2D3.4020706@redhat.com>
Date: Fri, 04 Mar 2016 18:24:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160304174859.GA15741@host1.jankratochvil.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-03/txt/msg00010.txt.bz2

On 03/04/2016 05:48 PM, Jan Kratochvil wrote:
> The bug with the parameter:
> (gdb) s
> p (m=0x7fffffffd2a0, n=1) at matrix2.c:9
> (gdb) ptype m
> type = int (*)[17]
> (gdb) p m
> $2 = (int (*)[17]) 0x7fffffffd2a0
> (gdb) p *m
> $3 = {-134241616, 32767, -134252848, 32767, -140382932, 32767, 2224, 0, -134252032, 32767, -136422399, 32767, 2224, 0, -140329216,
>    32767, -134252112}

It's a C gotcha, but I don't think it's a bug.  Essentially, a parameter
declared as an array is really treated as a pointer parameter.

>From http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf:

"
6.7.5.3 Function declarators (including prototypes)
Constraints
(...)

7

A declaration of a parameter as ‘‘array of type’’ shall be adjusted to ‘‘qualified pointer to type’’ (...)
"

So the DWARF describes the type as really what is is.  See:

~~~~~~~~~~~~~~~~
$ cat array-param.c
#include <stdlib.h>
#include <stdio.h>

enum
{
  sz = 17
};

void
p (int m[sz][sz])
{
  printf ("m: sizeof m = %d\n", (int) sizeof (m));
}

void
f (void)
{
  int m[sz][sz];

  printf ("f: sizeof m = %d\n", (int) sizeof (m));

  p (m);
}

int
main ()
{
  f ();
  return 0;
}

$ gcc -v
gcc version 6.0.0 20160301 (experimental) (GCC)
$ gcc array-param.c -o array-param -Wall -Wextra -O2
array-param.c: In function ‘p’:
array-param.c:12:46: warning: ‘sizeof’ on array function parameter ‘m’ will return size of ‘int (*)[17]’ [-Wsizeof-array-argument]
   printf ("m: sizeof m = %d\n", (int) sizeof (m));
                                              ^
array-param.c:10:8: note: declared here
 p (int m[sz][sz])
        ^
$ ./array-param 
f: sizeof m = 1156
m: sizeof m = 8
~~~~~~~~~~~~~~~~

Thanks,
Pedro Alves