From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28184 invoked by alias); 15 Sep 2015 18:14:52 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 28123 invoked by uid 89); 15 Sep 2015 18:14:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 18:14:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id CDA502ED14F; Tue, 15 Sep 2015 18:14:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FIEm0G015635; Tue, 15 Sep 2015 14:14:48 -0400 Message-ID: <55F86017.10504@redhat.com> Date: Tue, 15 Sep 2015 18:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Breazeal, Don" CC: "gdb@sourceware.org" Subject: Re: problem with new vforkdone stop reply in 7.10 References: <55F828D9.8050100@redhat.com> <55F8307D.5090305@redhat.com> In-Reply-To: <55F8307D.5090305@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00009.txt.bz2 On 09/15/2015 03:51 PM, Pedro Alves wrote: > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 395f0d4..3ac8c43 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -35498,10 +35498,11 @@ indicating support. > > @cindex vforkdone events, remote reply > @item vforkdone > -The packet indicates that a child process created by a vfork > -has either called @code{exec} or terminated, so that the > -address spaces of the parent and child process are no longer > -shared. The @var{r} part is ignored. This packet is only > +The packet indicates that a child process created by a vfork has > +either called @code{exec} or terminated, so that the address spaces of > +the parent and child process are no longer shared. The @var{r} part is > +the thread ID of the parent process. Refer to @ref{thread-id syntax} > +for the format of the @var{thread-id} field. This packet is only > applicable to targets that support vforkdone events. > Actually, I don't know what I was thinking when I wrote that docs patch. What I really think we should be doing is report the parent thread id with the usual "thread" magic register: Sending packet: $vCont;c:p7260.7260#1e...Packet received: OK - Notification received: Stop:T05vforkdone:; + Notification received: Stop:T05vforkdone:;06:40d7ffffff7f0000;07:30d7ffffff7f0000;10:e4c9eb1536000000;thread:p7260.7260;core:3; ^^^^^^^^^^^^^^^^^ This is already how the parent is reported in the vfork/fork events, and is actually what the code fix did. But somehow I blindly copied that "{r} part is the thread ID" doc bit from the fork event docu without realizing I was documenting it wrong. My bad... I'll fix that up. Thanks, Pedro Alves