Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>
Cc: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: problem with new vforkdone stop reply in 7.10
Date: Tue, 15 Sep 2015 15:56:00 -0000	[thread overview]
Message-ID: <55F83FA7.9090702@redhat.com> (raw)
In-Reply-To: <55F83D66.1010603@codesourcery.com>

On 09/15/2015 04:46 PM, Don Breazeal wrote:
> Thanks for taking care of this.  I don't think you are missing
> anything.  I think I just over-simplified the VFORK_DONE packet
> starting in my first implementation.  The changes make sense to
> me.  It seems like you have this covered, but let me know if I
> can help at all.

Writing tests would be a tremendous help.

> Absolutely, that should be report_exec_events.  I missed making that
> change from a previous version of the patchset that didn't use the
> report_xxx_events variables.

Alright, I'll split in two, and push then in.  Testing showed no
regressions.

> I've started looking at adding some tests to plug some of the gaps in
> fork/exec event testing.  Currently I'm looking at a test that kills the
> fork parent while stopped at a fork catchpoint.  It seems like I should
> add non-stop cases to foll-fork.exp and foll-vfork.exp as well.  And
> maybe the case where there are multiple vforks in progress at the same
> time, if I can come up with something that is reliable.

That would be much appreciated!

Thanks,
Pedro Alves


  reply	other threads:[~2015-09-15 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 14:19 Pedro Alves
2015-09-15 14:51 ` Pedro Alves
2015-09-15 15:46   ` Don Breazeal
2015-09-15 15:56     ` Pedro Alves [this message]
2015-09-15 18:14   ` Pedro Alves
2015-09-15 14:51 ` Don Breazeal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F83FA7.9090702@redhat.com \
    --to=palves@redhat.com \
    --cc=donb@codesourcery.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox