From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120283 invoked by alias); 15 Sep 2015 14:51:51 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 120220 invoked by uid 89); 15 Sep 2015 14:51:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 14:51:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 7A9A3C0B91B4; Tue, 15 Sep 2015 14:51:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FEpfAw029086; Tue, 15 Sep 2015 10:51:42 -0400 Message-ID: <55F8307D.5090305@redhat.com> Date: Tue, 15 Sep 2015 14:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Breazeal, Don" CC: "gdb@sourceware.org" Subject: Re: problem with new vforkdone stop reply in 7.10 References: <55F828D9.8050100@redhat.com> In-Reply-To: <55F828D9.8050100@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00006.txt.bz2 On 09/15/2015 03:19 PM, Pedro Alves wrote: > Hi Don, > > Unfortunately, I missed in review that the vforkdone stop reply > misses indicating the thread ID of the vfork parent which the > event relates to: I'm testing this. I wonder whether I'm missing some reason to keep the vforkdone switch case separate? At least foll-vfork.exp still passes. I should split this to a separate patch, but I also noticed that the TARGET_WAITKIND_EXECD handling checks multi_process instead of report_exec_events: - else if (status->kind == TARGET_WAITKIND_EXECD && multi_process) + else if (status->kind == TARGET_WAITKIND_EXECD && report_exec_events) which I think would be the check we want. Thanks, Pedro Alves >From 85989d3ce1cc931aa7025e21952136ef037388a1 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 15 Sep 2015 15:43:12 +0100 Subject: [PATCH] Fix vforkdone stop reply The vforkdone stop reply misses indicating the thread ID of the vfork parent which the event relates to: @cindex vfork events, remote reply @item vfork The packet indicates that @code{vfork} was called, and @var{r} is the thread ID of the new child process. Refer to @ref{thread-id syntax} for the format of the @var{thread-id} field. This packet is only applicable to targets that support vfork events. @cindex vforkdone events, remote reply @item vforkdone The packet indicates that a child process created by a vfork has either called @code{exec} or terminated, so that the address spaces of the parent and child process are no longer shared. The @var{r} part is ignored. This packet is only applicable to targets that support vforkdone events. Unfortunately, this is not just a documentation issue. GDBserver is really not specifying the thread ID. I noticed because in non-stop mode, gdb complains: [Thread 6089.6089] #1 stopped. #0 0x0000003615a011f0 in ?? () 0x0000003615a011f0 in ?? () (gdb) set debug remote 1 (gdb) c Continuing. Sending packet: $QPassSignals:e;10;14;17;1a;1b;1c;21;24;25;2c;4c;#5f...Packet received: OK Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK Notification received: Stop:T05vfork:p17ce.17ce;06:40d7ffffff7f0000;07:30d7ffffff7f0000;10:e4c9eb1536000000;thread:p17c9.17c9;core:2; Sending packet: $vStopped#55...Packet received: OK Sending packet: $D;17ce#af...Packet received: OK Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK Notification received: Stop:T05vforkdone:; No process or thread specified in stop reply: T05vforkdone:; (gdb) This is not non-stop-mode-specific, however. Consider e.g., that in all-stop, you may be debugging more than one process at the same time. You continue, and both processes vfork. So when you next get a T05vforkdone, there's no way to tell which of the parent processes is done with the vfork. gdb/ChangeLog: 2015-09-15 Pedro Alves * remote-utils.c (prepare_resume_reply): Merge TARGET_WAITKIND_VFORK_DONE switch case with the TARGET_WAITKIND_FORKED case. gdb/doc/ChangeLog: 2015-09-15 Pedro Alves * gdb.texinfo: Explain that vforkdone's 'r' part indicates the parent process. --- gdb/doc/gdb.texinfo | 9 +++++---- gdb/gdbserver/remote-utils.c | 19 ++++++++----------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 395f0d4..3ac8c43 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -35498,10 +35498,11 @@ indicating support. @cindex vforkdone events, remote reply @item vforkdone -The packet indicates that a child process created by a vfork -has either called @code{exec} or terminated, so that the -address spaces of the parent and child process are no longer -shared. The @var{r} part is ignored. This packet is only +The packet indicates that a child process created by a vfork has +either called @code{exec} or terminated, so that the address spaces of +the parent and child process are no longer shared. The @var{r} part is +the thread ID of the parent process. Refer to @ref{thread-id syntax} +for the format of the @var{thread-id} field. This packet is only applicable to targets that support vforkdone events. This packet should not be sent by default; older @value{GDBN} versions diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index ac86dd5..7cf66cc 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -1117,6 +1117,7 @@ prepare_resume_reply (char *buf, ptid_t ptid, case TARGET_WAITKIND_STOPPED: case TARGET_WAITKIND_FORKED: case TARGET_WAITKIND_VFORKED: + case TARGET_WAITKIND_VFORK_DONE: case TARGET_WAITKIND_EXECD: { struct thread_info *saved_thread; @@ -1135,7 +1136,13 @@ prepare_resume_reply (char *buf, ptid_t ptid, buf = write_ptid (buf, status->value.related_pid); strcat (buf, ";"); } - else if (status->kind == TARGET_WAITKIND_EXECD && multi_process) + else if (status->kind == TARGET_WAITKIND_VFORK_DONE && report_vfork_events) + { + enum gdb_signal signal = GDB_SIGNAL_TRAP; + + sprintf (buf, "T%02xvforkdone:;", signal); + } + else if (status->kind == TARGET_WAITKIND_EXECD && report_exec_events) { enum gdb_signal signal = GDB_SIGNAL_TRAP; const char *event = "exec"; @@ -1269,16 +1276,6 @@ prepare_resume_reply (char *buf, ptid_t ptid, else sprintf (buf, "X%02x", status->value.sig); break; - case TARGET_WAITKIND_VFORK_DONE: - if (report_vfork_events) - { - enum gdb_signal signal = GDB_SIGNAL_TRAP; - - sprintf (buf, "T%02xvforkdone:;", signal); - } - else - sprintf (buf, "T%02x", GDB_SIGNAL_0); - break; default: error ("unhandled waitkind"); break; -- 1.9.3