From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77793 invoked by alias); 17 Apr 2015 14:12:34 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 77782 invoked by uid 89); 17 Apr 2015 14:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 14:12:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HEBsOq019617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 10:11:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HEBmUM015649; Fri, 17 Apr 2015 10:11:49 -0400 Message-ID: <553114A4.9070906@redhat.com> Date: Fri, 17 Apr 2015 14:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Max Filippov CC: "gdb@sourceware.org" , Maxim Grigoriev , Woody LaRue , Marc Gauthier , "linux-xtensa@linux-xtensa.org" , Daniel Jacobowitz Subject: Re: [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS References: <1429233286-6240-1-git-send-email-jcmvbkbc@gmail.com> <1429233286-6240-3-git-send-email-jcmvbkbc@gmail.com> <5530EEA3.2040809@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00036.txt.bz2 On 04/17/2015 01:50 PM, Max Filippov wrote: > On Fri, Apr 17, 2015 at 2:29 PM, Pedro Alves wrote: >> On 04/17/2015 02:14 AM, Max Filippov wrote: >>> This fixes lbeg/lend/lcount registers handling through gdbserver. >>> >>> 2015-04-17 Max Filippov >>> gdb/gdbserver/ >>> * linux-xtensa-low.c (xtensa_fill_gregset, >>> xtensa_store_gregset): fix typo in XCHAL_HAVE_LOOPS >> >> I was curious on whether it might have been that XCHAL_HAVE_LOOP >> used to exist and was later renamed ("as in, how did this ever work > > It did work, only these three registers were inaccessible. That's what I'd call "not work". :-) (the point of that was that in case of a rename, it'd be probably better to check both XCHAL_HAVE_LOOP/XCHAL_HAVE_LOOPS.) >> OK with that change. > > Ok. Can I check it in (I have write-after-approval access to binutils), > or do I need to request such access to gdb separately? Once the copyright issue is sorted out, please add yourself to the gdb/MAINTAINERS file under Write After Approval. (it's preapproved, just push it in and post it to the gdb-patches@ list). Since the fixes/patches are trivial, it's OK to push them in before that is resolved. Feel free to do that any time. Thanks, Pedro Alves