From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13223 invoked by alias); 17 Apr 2015 11:29:36 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 13212 invoked by uid 89); 17 Apr 2015 11:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 11:29:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HBTPQv029462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 07:29:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HBTKkY005950; Fri, 17 Apr 2015 07:29:21 -0400 Message-ID: <5530EE90.7010109@redhat.com> Date: Fri, 17 Apr 2015 11:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Max Filippov , gdb@sourceware.org CC: Maxim Grigoriev , Woody LaRue , Marc Gauthier , linux-xtensa@linux-xtensa.org, Daniel Jacobowitz Subject: Re: [PATCH 1/2] gdbserver/xtensa: drop xtensa_usrregs_info References: <1429233286-6240-1-git-send-email-jcmvbkbc@gmail.com> <1429233286-6240-2-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1429233286-6240-2-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00033.txt.bz2 On 04/17/2015 02:14 AM, Max Filippov wrote: > xtensa_usrregs_info refers to undefined variables xtensa_num_regs and > xtensa_regmap. Drop xtensa_usrregs_info and replace pointer to usrregs > in regs_info with NULL since all registers are read/set through regsets. Eeek, that was added 2 years ago already... :-P > > 2015-04-17 Max Filippov > gdb/gdbserver/ > * linux-xtensa-low.c (xtensa_usrregs_info): remove. > (regs_info): replace usrregs pointer with NULL. Looks fine, thanks. Thanks, Pedro Alves