From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-44165-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 60490 invoked by alias); 27 Feb 2015 23:54:57 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 60470 invoked by uid 89); 27 Feb 2015 23:54:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Feb 2015 23:54:56 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1RNsqSs031633	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Fri, 27 Feb 2015 18:54:52 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1RNsoEF029138;	Fri, 27 Feb 2015 18:54:51 -0500
Message-ID: <54F103CA.3030807@redhat.com>
Date: Sat, 28 Feb 2015 06:13:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jack Howarth <howarth.mailing.lists@gmail.com>
CC: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: many -Wincompatible-pointer-types on clang with gdb-7.9
References: <CADtEn-344TMpjjbMmFzNfbyaR63t1-wS0Wv_JwNr3GYCNe+vJA@mail.gmail.com>	<54F0DC99.5020904@redhat.com>	<CADtEn-2orLcoUSem5RuK3LwF-RGauC8LXv8xZem0tGJsDwg0iA@mail.gmail.com> <CADtEn-13bHPwQJfQ2KvU4tTiFbZoWHAhirx5bQCEzRKq5aaH-g@mail.gmail.com>
In-Reply-To: <CADtEn-13bHPwQJfQ2KvU4tTiFbZoWHAhirx5bQCEzRKq5aaH-g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-02/txt/msg00087.txt.bz2

On 02/27/2015 11:33 PM, Jack Howarth wrote:
> The proposed patch doesn't eliminate the warnings...
> 
> ./guile/scm-arch.c:498:40: warning: incompatible pointer types
> initializing 'scm_t_subr' (aka 'void (*)()') with an expression of
> type 'SCM (SCM)'
>       [-Wincompatible-pointer-types]
>   { "arch?", 1, 0, 0, as_a_scm_t_subr (gdbscm_arch_p),
>                                        ^~~~~~~~~~~~~
> ./guile/guile-internal.h:93:31: note: expanded from macro 'as_a_scm_t_subr'
> #define as_a_scm_t_subr(func) func
>                               ^

That's because you didn't fully try what I suggested.  :-)

Here is is again:

I think you'll just need to do something like this on top:

 #else

 /* In C, just do an implicit conversion.  */
 -#define as_a_scm_t_subr(func) func
 +#define as_a_scm_t_subr(func) (scm_t_subr) func

 #endif

That's basically the same as adding a cast everywhere...

Thanks,
Pedro Alves