Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jack Howarth <howarth.mailing.lists@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
	Simon Marchi <simon.marchi@polymtl.ca>,
	       "Paul_Koning@dell.com" <Paul_Koning@dell.com>,
	       "gdb@sourceware.org" <gdb@sourceware.org>,
	       Paul Smith <paul@mad-scientist.net>
Subject: Re: format string is not a string literal
Date: Thu, 26 Feb 2015 19:55:00 -0000	[thread overview]
Message-ID: <54EF672F.3070509@redhat.com> (raw)
In-Reply-To: <CADtEn-1cbxgQnDVJYEUWDUsPJS1ai39Lc_CcxrnatMeDdr6jVQ@mail.gmail.com>

On 02/26/2015 04:48 PM, Jack Howarth wrote:
> Pedro,
>       It is almost complete except for...
> 
> ctf.c:109:39: warning: format string is not a string literal
> [-Wformat-nonliteral]
>   if (vfprintf (handler->metadata_fd, format, args) < 0)
>                                       ^~~~~~
> 
> and
> 
> ./guile/scm-utils.c:86:25: warning: format string is not a string
> literal [-Wformat-nonliteral]
>   string = xstrvprintf (format, args);
>                         ^~~~~~
> 

Thanks.  I've fixed those and pushed it in:

https://sourceware.org/ml/gdb-patches/2015-02/msg00780.html

Paul, I've improved the comment in vcomplain to clarify
the solution.  Thanks for poking about that.

Thanks,
Pedro Alves


  reply	other threads:[~2015-02-26 18:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 17:16 Jack Howarth
2015-02-24 18:18 ` Andrew Pinski
2015-02-24 18:04   ` Andrew Pinski
2015-02-25  7:58 ` Paul_Koning
2015-02-26  0:06   ` Jack Howarth
2015-02-26  0:12     ` Paul_Koning
     [not found]       ` <CAFXXi0=56gNf2GoSKkrx=bRArhjk+AhSbiu0crpdR3=df7B2BQ@mail.gmail.com>
2015-02-26  0:46         ` pinskia
2015-02-26  2:31           ` Jack Howarth
2015-02-26  2:35             ` pinskia
2015-02-26  2:38               ` Simon Marchi
2015-02-26  8:39                 ` Andrew Pinski
2015-02-26  8:46                   ` Andrew Pinski
2015-02-26  9:52                     ` Jack Howarth
2015-02-26 10:18                       ` Andrew Pinski
2015-02-26 16:26             ` Pedro Alves
2015-02-26 17:44               ` Jack Howarth
2015-02-26 19:55                 ` Pedro Alves [this message]
2015-02-26 18:34               ` Paul Smith
2015-02-26 19:41                 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF672F.3070509@redhat.com \
    --to=palves@redhat.com \
    --cc=Paul_Koning@dell.com \
    --cc=gdb@sourceware.org \
    --cc=howarth.mailing.lists@gmail.com \
    --cc=paul@mad-scientist.net \
    --cc=pinskia@gmail.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox