From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21881 invoked by alias); 21 Aug 2014 15:49:13 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 21867 invoked by uid 89); 21 Aug 2014 15:49:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: OARmail.OARCORP.com Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Aug 2014 15:49:12 +0000 Received: from [192.168.1.169] (192.168.1.169) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.342.0; Thu, 21 Aug 2014 10:49:08 -0500 Message-ID: <53F614F3.9070307@oarcorp.com> Date: Thu, 21 Aug 2014 15:49:00 -0000 From: Joel Sherrill User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "gdb@sourceware.org" Subject: Re: Multiple Target Failures for Multiple Definition of debug_printf References: <53F60937.2030404@oarcorp.com> In-Reply-To: <53F60937.2030404@oarcorp.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00112.txt.bz2 I hate to follow up to myself but the references to debug_printf() in sim/ were the prototype, body, and multiple ChangeLog entries. I if 0'ed the sim/ debug_printf() out and bfin now links. Can someone else confirm that the debug_printf() under sim/ is unused and can be deleted? Thanks. --joel On 8/21/2014 9:59 AM, Joel Sherrill wrote: > Hi > > I reported this earlier but wanted to provide some more details. > > Multiple architectures fail when linking gdb due to debug_printf() > being multiply defined. > > The architectures are: bfin, h8300, lm32, mips, moxie, and v850. > > The debug_printf() in gdb/common/common-debug.c is very > simple. But the one in sim/common/sim-trace.c is more > complicated and has awareness of the simulator state. > Thus they can't be folded into one method. > > There are 7 calls to debug_printf() in the sim/ tree but 203 > in the gdb/ tree. > > This all leads me to believe that the solution is to change > the name of the debug_printf() in sim/ to something like > sim_debug_printf(). > > Thoughts? > -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985