Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: Bob Rossi <bob@brasko.net>
Cc: gdb@sourceware.org
Subject: Re: GDB/MI async output token field
Date: Thu, 29 May 2014 17:04:00 -0000	[thread overview]
Message-ID: <5386B6F1.1010708@cs.msu.su> (raw)
In-Reply-To: <20140529024922.GA3072@linux>

On 05/29/2014 06:49 AM, Bob Rossi wrote:
> On Tue, May 27, 2014 at 11:55:49AM -0400, Bob Rossi wrote:
>> On Sun, May 25, 2014 at 11:16:05AM +0400, Vladimir Prus wrote:
>>> On 05/23/2014 05:14 AM, Bob Rossi wrote:
>>>> On this page,
>>>> https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Output-Syntax.html#GDB_002fMI-Output-Syntax
>>>>
>>>> The documentation says,
>>>>   Note that for all async output, while the token is allowed by the
>>>>   grammar and may be output by future versions of gdb for select async
>>>>   output messages, it is generally omitted.
>>>>
>>>>   Frontends should treat all async output as reporting general changes in
>>>>   the state of the target and there should be no need to associate async
>>>>   output to any prior command.
>>>>
>>>> I searched through the GDB source code and can't find a single place
>>>> where this occurs.
>>>
>>> such clarification will be good.
>>
>> 2008-04-24  Vladimir Prus  <vladimir@codesourcery.com>
>>
>>          * gdb.texinfo (GDB/MI Output Syntax): Clarify that async
>>           output does not necessary include any tokens.
>>
>> That looked a little suspicous. That is, perhaps there are cases were
>> the token is in the async output?
>>
> Perhaps I was unclear. I have a patch that removes the [token] syntax
> from the GDB manual regarding async output.
>
> I found your commit message that added a note that stated async
> output does not necessarily include tokens.
>
> The note made me think that at the time, you knew of at least one case
> where async output would include the token (or you would have removed
> the token syntax from the async output instead of saying that the token
> might not be included).
>
> Can you (or anyone) recall a case where GDB would output a token with an
> async record?
>
> I don't want to post a patch that removes the token syntax from the gdb
> manual if indeed someone will run into it in the wild. That makes the
> situation worse, not better.

The ChangeLog entry is useless, as usual. Here are relevant emails:

	https://sourceware.org/ml/gdb/2008-03/msg00239.html
	https://sourceware.org/ml/gdb-patches/2008-04/msg00202.html

The was single case where token was included in async output, and I removed
that. I don't believe any new cases were added, and nobody was upset in
all that time, so adjusting documentation to say that async output
never includes any tokens seems reasonable to me.

- Volodya


  reply	other threads:[~2014-05-29  4:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  1:13 Bob Rossi
2014-05-25  7:16 ` Vladimir Prus
2014-05-26  0:14   ` Vladimir Prus
2014-05-28  7:59   ` Bob Rossi
2014-05-29  4:26     ` Bob Rossi
2014-05-29 17:04       ` Vladimir Prus [this message]
2014-05-29 19:22         ` Bob Rossi
2014-06-04 20:28           ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386B6F1.1010708@cs.msu.su \
    --to=ghost@cs.msu.su \
    --cc=bob@brasko.net \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox