From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1142 invoked by alias); 9 Jan 2014 18:46:28 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 1132 invoked by uid 89); 9 Jan 2014 18:46:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: samersoff.net Received: from Unknown (HELO samersoff.net) (81.9.105.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 18:46:26 +0000 Received: from [192.168.0.77] (port=43002 helo=dooku.mircat.net) by samersoff.net with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.82) (envelope-from ) id 1W1KcV-0008Fl-Od; Thu, 09 Jan 2014 22:46:19 +0400 Message-ID: <52CEEE7B.50506@samersoff.net> Date: Thu, 09 Jan 2014 18:46:00 -0000 From: Dmitry Samersoff User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Joel Brobecker , Phil Muldoon CC: gdb@sourceware.org Subject: Re: Trailing Whitespace References: <20140109144455.GA2972@blade.nx> <20140109145731.GA13720@localhost.localdomain> <20140109150145.GA3788@adacore.com> In-Reply-To: <20140109150145.GA3788@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00010.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 IMHO, better approach is to install on-commit hook blocking commits with trailing whitespace (and tab characters) and leave old code as is. On 2014-01-09 19:01, Joel Brobecker wrote: >> Also (and I am not sure if git can get around this somehow) >> whitespace cleanups tend to obliterate diffs/patches that were >> written before the cleanup took place. This makes merging a >> massive pain. >> >> So my 2 pence worth is, no, not a good idea ;) > > Strongly seconded. Localized whitespace fixes are OK, because > manageable in the amount of work they generate, but please, not a > massive cleanup. And if we ever do that massive cleanup, I would > request that a pre-requisite is an "update" check on the git server > that rejects pushes of files violating that rule. > > On my end of things, I configured my editor to simply highlight > trailing spaces, not strip them. > - -- Dmitry Samersoff Saint Petersburg, Russia, http://devnull.samersoff.net * There will come soft rains ... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSzu57AAoJEHEy08c4gIABafIH/RMOU8+mzZts8yRFUKHKB1D/ 89sG/dfLWTShhJoK4omD9h4BzntQgzBviyhEsQuaAgYATg+3Ok503wd+WhEEkVub IqqXoz4Pu/2GSu2sWzNT9o+sXudUH/gyGsG+/ISVsBr1yF7WMSUMl8TLeOTJMUi6 hY/7lrBfNVFxEnKXS94sdf98dXCz1oGWQXDt9zv26zeayhKjMx41A11IQTZN5Lrd yMdyd4O4/r+9T6otii1utnDTQwYfRGiOb+UFoE7bD+blEL5pqSDLHsYcXpmnvhXE sAc3Koa33KimE6krJsFoKSZPDxXbefb/48e959VqF6/1Nh1/qxWmY6lonqHA0Rg= =2WWt -----END PGP SIGNATURE-----