From: nick clifton <nickc@redhat.com>
To: Pedro Alves <palves@redhat.com>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'asmwarrior'" <asmwarrior@gmail.com>,
"'GDB Development'" <gdb@sourceware.org>,
"'Binutils Development'" <binutils@sourceware.org>
Subject: Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
Date: Thu, 19 Dec 2013 11:15:00 -0000 [thread overview]
Message-ID: <52B2D49E.4080906@redhat.com> (raw)
In-Reply-To: <52B1E1B0.4040400@redhat.com>
Hi Pedro, Hi Pierre,
Pedro Alves wrote:
> On 12/18/2013 01:02 PM, Pierre Muller wrote:
>> -#ifdef __CYGWIN__
>> +#if defined __CYGWIN__ || defined __MINGW32__
>> +#ifdef __MINGW32__
>> +#define wcsncasecmp wcsnicmp
>> +#endif
>> /* Under Cygwin unicode == UTF-16 == wchar_t.
>> FIXME: The same is true for MingGW - we should test for that too. */
>
> Isn't this FIXME note stale now?
True - Pierre: would you mind removing the FIXME comment as well, when
you check in your patch please ?
Cheers
Nick
next prev parent reply other threads:[~2013-12-19 11:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 9:54 GDB MinGW build error: implicit declaration of function 'wcsncasecmp' asmwarrior
2013-12-18 9:58 ` asmwarrior
2013-12-18 10:06 ` BFD " Pedro Alves
2013-12-18 12:50 ` asmwarrior
2013-12-18 15:47 ` Eli Zaretskii
2013-12-18 13:03 ` [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c Pierre Muller
2013-12-18 17:52 ` nick clifton
2013-12-19 11:45 ` [RFC-v2] " Pierre Muller
2013-12-19 12:41 ` nick clifton
2013-12-19 13:02 ` Mark Kettenis
2013-12-19 13:18 ` Pierre Muller
2013-12-19 15:13 ` nick clifton
[not found] ` <52b19d01.22cbc20a.69b0.ffffb29eSMTPIN_ADDED_BROKEN@mx.google.com>
2013-12-18 13:25 ` [RFC] " asmwarrior
[not found] ` <52b19d19.0850420a.7b6a.52dcSMTPIN_ADDED_BROKEN@mx.google.com>
2013-12-18 17:56 ` Pedro Alves
2013-12-19 11:15 ` nick clifton [this message]
2013-12-18 15:35 ` GDB MinGW build error: implicit declaration of function 'wcsncasecmp' Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B2D49E.4080906@redhat.com \
--to=nickc@redhat.com \
--cc=asmwarrior@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb@sourceware.org \
--cc=palves@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox