From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-42930-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 30731 invoked by alias); 18 Dec 2013 17:56:09 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 30712 invoked by uid 89); 18 Dec 2013 17:56:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 17:56:08 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIHu3NA001602	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 18 Dec 2013 12:56:03 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBIHu1aJ011989;	Wed, 18 Dec 2013 12:56:01 -0500
Message-ID: <52B1E1B0.4040400@redhat.com>
Date: Wed, 18 Dec 2013 17:56:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
CC: "'asmwarrior'" <asmwarrior@gmail.com>,        "'GDB Development'" <gdb@sourceware.org>,        "'Binutils Development'" <binutils@sourceware.org>
Subject: Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
References: <52B17083.7040404@gmail.com> <52B1738D.4010409@redhat.com> <52b19d19.0850420a.7b6a.52dcSMTPIN_ADDED_BROKEN@mx.google.com>
In-Reply-To: <52b19d19.0850420a.7b6a.52dcSMTPIN_ADDED_BROKEN@mx.google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-12/txt/msg00054.txt.bz2

On 12/18/2013 01:02 PM, Pierre Muller wrote:
> -#ifdef __CYGWIN__
> +#if defined  __CYGWIN__ || defined __MINGW32__
> +#ifdef __MINGW32__
> +#define wcsncasecmp wcsnicmp
> +#endif
>    /* Under Cygwin unicode == UTF-16 == wchar_t.
>       FIXME: The same is true for MingGW - we should test for that too.  */

Isn't this FIXME note stale now?

> +  bfd_byte *    astring = a->name_id.name.string;
> +  unsigned int  alen    = a->name_id.name.len;
> +  bfd_byte *    bstring = b->name_id.name.string;
> +  unsigned int  blen    = b->name_id.name.len;
>    res = wcsncasecmp ((const wchar_t *) astring + 2, (const wchar_t *) bstring + 2, min (alen, blen));
>  #elif defined HAVE_WCHAR_H
>    unsigned int  i;

-- 
Pedro Alves