From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Arnab Bhaduri <arnab@cadence.com>,
"gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: gdb not detecting function sections correctly for functions in overlays
Date: Tue, 22 Oct 2013 17:32:00 -0000 [thread overview]
Message-ID: <5266B694.5090006@redhat.com> (raw)
In-Reply-To: <8738ntgsd1.fsf@fleche.redhat.com>
On 10/22/2013 05:52 PM, Tom Tromey wrote:
>>>>>> "Arnab" == Arnab Bhaduri <arnab@cadence.com> writes:
>
> Arnab> I have made a couple of local changes that make things work better for
> Arnab> me. Perhaps you could give me your opinion on these (described below).
>
> Arnab> 1) add_location_to_breakpoint() (breakpoint.c) - this calls
> Arnab> set_breakpoint_location_function() which sets the function name
> Arnab> incorrectly because it uses the PC-to-section lookup. I modified this
> Arnab> like so:
> [...]
>
> I think a patch would be simpler to understand.
Assuming the patch is either small (10 lines or so), or we can get the
copyright assigned, which would be great. I don't see Cadence mentioned
in copyright.list though.
Otherwise, a description of the bug might actually be better, for allowing
a clean room implementation.
--
Pedro Alves
next prev parent reply other threads:[~2013-10-22 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 20:02 Arnab Bhaduri
2013-10-10 18:03 ` Tom Tromey
2013-10-14 16:29 ` Arnab Bhaduri
2013-10-22 16:53 ` Tom Tromey
2013-10-22 17:32 ` Pedro Alves [this message]
2013-10-22 17:38 ` Arnab Bhaduri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5266B694.5090006@redhat.com \
--to=palves@redhat.com \
--cc=arnab@cadence.com \
--cc=gdb@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox