Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Julian Smith <jules@op59.net>
Cc: gdb@sourceware.org
Subject: Re: Current gdb python errors on python-2.4
Date: Tue, 11 Jun 2013 13:34:00 -0000	[thread overview]
Message-ID: <51B72757.9050902@redhat.com> (raw)
In-Reply-To: <20130609035926.40bad3bb.jules@op59.net>

On 09/06/13 03:59, Julian Smith wrote:
> I think gdb in cvs has some python that is not supported by python-2.4
> (e.g. on centos5) - code like 'except Exception as e:'.
> 
> This leads to startup warnings like:
> 
>     [jules@vm-centos5 ~]$ ./gdb_cvs_dir/src/gdb/gdb -data-directory gdb_cvs_dir/src/gdb/data-directory
>     Traceback (most recent call last):
>       File "/home/jules/gdb_cvs_dir/src/gdb/data-directory/python/gdb/__init__.py", line 105, in auto_load_packages
>         __import__(modname)
>       File "gdb_cvs_dir/src/gdb/data-directory/python/gdb/command/frame_filters.py", line 82
>         except Exception as e:
>                           ^
>     SyntaxError: invalid syntax


> - and subsequent use of python from within gdb fails.
> 
> I think simply replacing the 'as' with a comma will allow the code to
> work with all python versions ?

Unfortunately not, this is one messy area of Python.  Python 2.0 - 2.5
supports only:

except Exception, e:

Python 2.6 and 2.7 support both:

except Exception, e:

and

exception Exception as e:

But Python 3 only supports:

exception Exception as e:

The only way (I know) to get exceptions to work for all versions of
Python is to do something like:

except Exception:
       e = sys.exc_info[1]


> Here's a patch that works for me:


So you will have to re-factor your patch.  Also, patches are sent to
gdb-patches@sourceware.org.  gdb@sourceware.org is more for questions
about GDB.

Also your patch needs a ChangeLog entry, and possibly you may need
paperwork on file with the FSF (the maintainers can help you with that
if it is deemed needed).

Cheers,

Phil


       reply	other threads:[~2013-06-11 13:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130609035926.40bad3bb.jules@op59.net>
2013-06-11 13:34 ` Phil Muldoon [this message]
2013-06-11 13:37   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B72757.9050902@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=jules@op59.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox