From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17483 invoked by alias); 15 May 2013 11:03:05 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 17473 invoked by uid 89); 15 May 2013 11:03:04 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 11:03:03 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UcZU5-0005GU-Nd from Luis_Gustavo@mentor.com ; Wed, 15 May 2013 04:03:01 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 15 May 2013 04:03:02 -0700 Received: from [172.30.8.147] ([172.30.8.147]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 15 May 2013 04:03:01 -0700 Message-ID: <51936B62.7030802@codesourcery.com> Date: Wed, 15 May 2013 11:03:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Christian Groessler CC: gdb@sourceware.org Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion References: <51936596.8010205@groessler.org> In-Reply-To: <51936596.8010205@groessler.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00060.txt.bz2 On 05/15/2013 12:38 PM, Christian Groessler wrote: > Hi, > > I had some testsuite failures in gdb.dwarf2/dw2-dir-file-name.exp, > because /bin/sh on my system doesn't support brace expansion. > I'm using Debian, where /bin/sh is in fact dash. I tried /bin/sh on > Solaris (9), too, and it also doesn't support brace expansion. > > This patch changes dw2-dir-file-name.exp to use bash instead of sh. > > Ok to commit? > > regards, > chris > > > > gdb/testsuite: > 2013-05-15 Christian Groessler > > * gdb.dwarf2/dw2-dir-file-name.exp: Use bash instead of sh, since > brace expansion is not available in sh. > > > > Index: gdb.dwarf2/dw2-dir-file-name.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp,v > retrieving revision 1.4 > diff -u -p -r1.4 dw2-dir-file-name.exp > --- gdb.dwarf2/dw2-dir-file-name.exp 15 Mar 2013 01:41:28 -0000 1.4 > +++ gdb.dwarf2/dw2-dir-file-name.exp 15 May 2013 10:27:20 -0000 > @@ -322,10 +322,10 @@ if { [gdb_compile "${asmsrcfile} ${srcdi > return -1 > } > > -remote_exec host "sh -c \"rm -f > ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}/${srctmpfile}\"" > -remote_exec host "sh -c \"rmdir > ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}\"" > -remote_exec host "sh -c \"mkdir > ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir}\"" > -remote_exec host "sh -c \"for d in > ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir};do cp > ${srcdir}/${subdir}/${srcfile} \\\$d/${srctmpfile}; done\"" > +remote_exec host "bash -c \"rm -f > ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}/${srctmpfile}\"" > +remote_exec host "bash -c \"rmdir > ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}\"" > +remote_exec host "bash -c \"mkdir > ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir}\"" > +remote_exec host "bash -c \"for d in > ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir};do cp > ${srcdir}/${subdir}/${srcfile} \\\$d/${srctmpfile}; done\"" > > clean_restart ${testfile} > > > > Speaking of which, i see quite a few failures with this testcase, in the form of: FAIL: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: continue to breakpoint: compdir_missing__ldir_missing__file_basename PASS: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: set filename-display absolute FAIL: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: absolute PASS: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: set filename-display basename FAIL: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: basename Not sure if it is related.