From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31819 invoked by alias); 15 May 2013 10:38:26 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 31810 invoked by uid 89); 15 May 2013 10:38:26 -0000 X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,MAY_BE_FORGED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from vigilia.groessler.org (HELO vigilia.groessler.org) (178.63.177.85) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 10:38:25 +0000 Received: from [10.23.1.38] (gaga.groessler.org [212.168.189.235] (may be forged)) by vigilia.groessler.org (8.14.6/8.14.6) with ESMTP id r4FAca5E030609 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 15 May 2013 12:38:36 +0200 (CEST) Message-ID: <51936596.8010205@groessler.org> Date: Wed, 15 May 2013 10:38:00 -0000 From: Christian Groessler User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: gdb@sourceware.org Subject: [patch]: testsuite: run bash instead of sh when using brace expansion Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00058.txt.bz2 Hi, I had some testsuite failures in gdb.dwarf2/dw2-dir-file-name.exp, because /bin/sh on my system doesn't support brace expansion. I'm using Debian, where /bin/sh is in fact dash. I tried /bin/sh on Solaris (9), too, and it also doesn't support brace expansion. This patch changes dw2-dir-file-name.exp to use bash instead of sh. Ok to commit? regards, chris gdb/testsuite: 2013-05-15 Christian Groessler * gdb.dwarf2/dw2-dir-file-name.exp: Use bash instead of sh, since brace expansion is not available in sh. Index: gdb.dwarf2/dw2-dir-file-name.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp,v retrieving revision 1.4 diff -u -p -r1.4 dw2-dir-file-name.exp --- gdb.dwarf2/dw2-dir-file-name.exp 15 Mar 2013 01:41:28 -0000 1.4 +++ gdb.dwarf2/dw2-dir-file-name.exp 15 May 2013 10:27:20 -0000 @@ -322,10 +322,10 @@ if { [gdb_compile "${asmsrcfile} ${srcdi return -1 } -remote_exec host "sh -c \"rm -f ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}/${srctmpfile}\"" -remote_exec host "sh -c \"rmdir ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}\"" -remote_exec host "sh -c \"mkdir ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir}\"" -remote_exec host "sh -c \"for d in ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir};do cp ${srcdir}/${subdir}/${srcfile} \\\$d/${srctmpfile}; done\"" +remote_exec host "bash -c \"rm -f ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}/${srctmpfile}\"" +remote_exec host "bash -c \"rmdir ${srcabsdir}{/rdir,}{/xdir,}{/compdir,}{/ldir,}{/fdir,}\"" +remote_exec host "bash -c \"mkdir ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir}\"" +remote_exec host "bash -c \"for d in ${srcabsdir}{,/rdir}{,/xdir}{,/compdir}{,/ldir}{,/fdir};do cp ${srcdir}/${subdir}/${srcfile} \\\$d/${srctmpfile}; done\"" clean_restart ${testfile}