From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20677 invoked by alias); 6 Dec 2012 16:21:07 -0000 Received: (qmail 20664 invoked by uid 22791); 6 Dec 2012 16:21:05 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 16:20:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6GKgdQ022003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Dec 2012 11:20:42 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB6GKIlV004333; Thu, 6 Dec 2012 11:20:36 -0500 Message-ID: <50C0C5C1.4070101@redhat.com> Date: Thu, 06 Dec 2012 16:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: Mathieu Desnoyers , Hui Zhu , Julien Desfossez , lttng-dev , Tom Tromey , gdb@sourceware.org Subject: Re: [lttng-dev] Request change name of function lookup_enum in libbabeltrace to make GDB use this lib References: <20121205120845.GA31696@Krystal> <50C0C06A.40207@redhat.com> In-Reply-To: <50C0C06A.40207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00028.txt.bz2 On 12/06/2012 03:57 PM, Pedro Alves wrote: > On 12/05/2012 12:08 PM, Mathieu Desnoyers wrote: >> * Hui Zhu (teawater@gmail.com) wrote: >>> Hi, >>> >>> I am working on add CTF support to GDB. You can see my patch review threads in: >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00552.html >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00554.html >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00553.html >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00556.html >>> >>> To make GDB support CTF read, I use libbabeltrace with GDB. You can >>> see the patch in >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html. >>> I have a issue is libbabeltrace have a function called lookup_enum >>> that is same with a GDB function. >>> I change the function name of GDB to handle this issue in my patch. >>> >>> But Tom said let libbabeltrace to change function name is better. >>> So I send this mail to ask do you mind change the function name of >>> lookup_enum? If you can change the function name that will be really >>> helpful for us. Thanks a lot. >>> And I post a patch about change the function name in libbabeltrace. >> >> I'm CCing Julien Desfossez on this one. From what I see, >> include/babeltrace/types.h is not included into the system, so it should >> not be considered to be a public header of libbabeltrace. > > I've just built and installed babeltrace 1.0.0 (where's the mainline repository, > BTW?), and indeed, I'm not seeing the types.h file anywhere in the > installed tree: (found mainline at http://www.efficios.com/babeltrace) I installed mainline, and quickly skimmed the headers. It seems most of the symbols are already namespace clean, using bt_ or babeltrace_ as prefix, but I did spot some problems: context.h: struct bt_context; struct stream_pos; ^^^^^^^^^^^^^^^^^ struct bt_ctf_event; ctf/events.h: struct definition; ^^^^^^^^^^^^^^^^^ struct declaration; ^^^^^^^^^^^^^^^^^^ struct bt_ctf_event; struct bt_ctf_event_decl; struct bt_ctf_field_decl; It'd be very good if those (and any others I might have missed) were bt_ prefixed too. Thanks, -- Pedro Alves