From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31879 invoked by alias); 6 Dec 2012 15:38:45 -0000 Received: (qmail 31865 invoked by uid 22791); 6 Dec 2012 15:38:43 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 15:38:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6FcXmA018196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Dec 2012 10:38:34 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB6FcWNN014936; Thu, 6 Dec 2012 10:38:33 -0500 Message-ID: <50C0BBF7.7040100@redhat.com> Date: Thu, 06 Dec 2012 15:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: John Gilmore CC: Hui Zhu , gdb@sourceware.org Subject: Re: Request change name of function lookup_enum in libbabeltrace to make GDB use this lib References: <201212061051.qB6Ap9CU012302@new.toad.com> In-Reply-To: <201212061051.qB6Ap9CU012302@new.toad.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00026.txt.bz2 On 12/06/2012 10:51 AM, John Gilmore wrote: > I suggest that it's best if both GDB and Libbabeltrace change the name > of lookup_enum. That way you'll be able to compile any version of GDB > with any version of libbabeltrace (fixed or unfixed) and all four > combinations will work except "unfixed GDB" and "unfixed > libbabeltrace"). > > If you just change it in the library, gdb stops building on machines that > have the old library. > > If you just change it in GDB, older gdb's won't be compatible with > newer libraries. Hmm, but older gdb's don't link with that library > anyway. So you might as well just fix it in GDB; that works for all > cases. AFAICS, this is a pretty new library. It isn't even packaged in Fedora for example. And this is new functionality. There's no need to rush this out. Libraries should be good citizens and put their external visible symbols in a namespace, which in C amounts to prefixing their symbols with ctf_ or whatever. We should not consider adjusting GDB until we're shure upstream babeltrace has fully addressed the issue (which it seems it will). Then the question at that point becomes one of considering whether we want to support building with the old broken versions or just forget them. -- Pedro Alves