From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4438 invoked by alias); 12 Nov 2012 18:28:04 -0000 Received: (qmail 4426 invoked by uid 22791); 12 Nov 2012 18:28:03 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 18:27:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qACIRorx010541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Nov 2012 13:27:50 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qACIHGso027769; Mon, 12 Nov 2012 13:17:18 -0500 Message-ID: <50A13D2C.7070207@redhat.com> Date: Mon, 12 Nov 2012 18:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Pierre Muller , gdb@sourceware.org Subject: Re: New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory References: <002701cdc0b9$542d2560$fc877020$@muller@ics-cnrs.unistra.fr> <20121112180707.GQ4847@adacore.com> In-Reply-To: <20121112180707.GQ4847@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00011.txt.bz2 On 11/12/2012 06:07 PM, Joel Brobecker wrote: >> 1) is a little bit more tricky because safe_strerror is declared in utils.h >> header, >> but implemented in two files: >> posix-hdep.c and mingw-hdep.c >> >> Should I extract the declaration into a >> gdb/common/gdb_strerror.h >> and extract the two functions >> into gdb/common/posix-strerror.c and gdb/common/mingw-strerror.c? > > This sounds good to me. There is the option of putting all > implementation into one single file, the way we do for some > of our code, but I don't think it would be particularly simpler > to do that way, since the current code has it separated in 2 files. > > In terms of the name, perhaps we should make it more explicit that > this is not strerror, but safe_strerror? strerror sounds like something gnulib might have a replacement for too. Then we could get rid of safe_strerror, and just use strerror everywhere. -- Pedro Alves