From: Ralf Corsepius <ralf.corsepius@rtems.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb@sourceware.org, Ralf Corsepius <ralf.corsepius@rtems.org>
Subject: Re: gdb-7.4 bfin simulator fails to build on Fedora 17
Date: Wed, 25 Jan 2012 06:18:00 -0000 [thread overview]
Message-ID: <4F1F9DFF.7040506@rtems.org> (raw)
In-Reply-To: <201201241559.32809.vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]
On 01/24/2012 09:59 PM, Mike Frysinger wrote:
> On Tuesday 24 January 2012 12:56:15 Ralf Corsepius wrote:
>> gdb-7.4's bfin simulator fails to build for bfin-rtems* targets on
>> Fedora 17/RH rawhide:
>>
>> ....
>> In file included from /usr/include/linux/ethtool.h:17:0,
>> from /usr/include/linux/mii.h:12,
>> from ../../../gdb-7.4/sim/bfin/dv-eth_phy.c:31:
>> /usr/include/linux/if_ether.h:130:2: error: unknown type name '__be16'
>> In file included from /usr/include/linux/mii.h:12:0,
>> from ../../../gdb-7.4/sim/bfin/dv-eth_phy.c:31:
>> /usr/include/linux/ethtool.h:21:2: error: unknown type name '__u32'
>> /usr/include/linux/ethtool.h:22:2: error: unknown type name '__u32'
>> /usr/include/linux/ethtool.h:23:2: error: unknown type name '__u32'
>> /usr/include/linux/ethtool.h:28:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:29:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:30:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:31:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:32:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:33:2: error: unknown type name '__u8'
>> /usr/include/linux/ethtool.h:34:2: error: unknown type name '__u32'
>> /usr/include/linux/ethtool.h:35:2: error: unknown type name '__u32'
>> ...
>>
>> The same configuration builds fine for Fedora 15/16 and openSUSE-11.4/12.1.
>>
>> From what I gather, the bfin simulator chokes upon kernel header
>> incompatiblities.
>
> hmm, in linux-3.2 (and older), linux/mii.h doesn't include anything else.
> seems linux-3.3-rc1 has started including linux/ethtool.h too. however, that
> is unnecessary for userspace, so i'll probably send a patch to move the
> include to __KERNEL__.
>
> dv-eth_phy.c has some hacks in it to make it build with even older kernel
> headers. maybe i should have it just not build that driver on older systems
> rather than try to support it ...
FWIW: With the patch below applied, gdb-7.4's bfin simulator at least
builds for me (--target=bfin-rtems4.11) for Centos-{5,6}-{i386,x86_64},
fedora-{15,16,17}-{i386,x86_64} and openSUSE-{11.4,12.1}-{i586,x86_64}.
Seems to me, as if some of the hacks aren't required on any of these
distros and harmful on bleeding edge distros ;)
Ralf
[-- Attachment #2: gdb-7.4-sim-bfin.diff --]
[-- Type: text/x-patch, Size: 420 bytes --]
diff -Naur gdb-7.4.orig/sim/bfin/dv-eth_phy.c gdb-7.4/sim/bfin/dv-eth_phy.c
--- gdb-7.4.orig/sim/bfin/dv-eth_phy.c 2012-01-06 05:54:38.000000000 +0100
+++ gdb-7.4/sim/bfin/dv-eth_phy.c 2012-01-25 05:35:16.204109337 +0100
@@ -25,9 +25,6 @@
#ifdef HAVE_LINUX_MII_H
-/* Workaround old/broken linux headers. */
-#define _LINUX_TYPES_H
-#define __u16 unsigned short
#include <linux/mii.h>
#define REG_PHY_SIZE 0x20
next prev parent reply other threads:[~2012-01-25 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 17:58 Ralf Corsepius
2012-01-24 20:59 ` Mike Frysinger
2012-01-25 6:18 ` Ralf Corsepius [this message]
2012-01-25 6:44 ` Mike Frysinger
2012-03-04 19:57 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1F9DFF.7040506@rtems.org \
--to=ralf.corsepius@rtems.org \
--cc=gdb@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox