From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8445 invoked by alias); 5 Jun 2010 00:44:16 -0000 Received: (qmail 8426 invoked by uid 22791); 5 Jun 2010 00:44:15 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Jun 2010 00:44:11 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B3D713D009; Fri, 4 Jun 2010 17:44:08 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id AA523C9A2C; Fri, 4 Jun 2010 17:44:08 -0700 (PDT) Message-ID: <4C099DD8.5050403@vmware.com> Date: Sat, 05 Jun 2010 00:44:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Pedro Alves CC: "gdb@sourceware.org" Subject: Re: Help, minor bug in testsuite References: <4C097DAF.3090100@vmware.com> <201006050039.57654.pedro@codesourcery.com> In-Reply-To: <201006050039.57654.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00021.txt.bz2 Pedro Alves wrote: > On Friday 04 June 2010 23:26:55, Michael Snyder wrote: >> OK, not sure what to do with this one. The test in gdb.base/list.exp >> says: >> >> # Try listsize of 0 which suppresses printing. >> >> set_listsize 0 >> gdb_test "list 1" "" "listsize of 0 suppresses output" >> >> >> However, the test only passes because "" is the same as ".*". >> In fact, the output is NOT suppressed, and I can find nowhere >> in the documentation that says it SHOULD be suppressed. > > (Without commenting on whether setting listsize to 0 to suppress > output had any value,) it appears to be a regression at some > point. Note with GDB 6.0: > > >~/gdb/ancient/build-6.0/gdb/gdb ~/gdb/tests/main32 > GNU gdb 6.0 > Copyright 2003 Free Software Foundation, Inc. > GDB is free software, covered by the GNU General Public License, and you are > welcome to change it and/or distribute copies of it under certain conditions. > Type "show copying" to see the conditions. > There is absolutely no warranty for GDB. Type "show warranty" for details. > This GDB was configured as "i686-pc-linux-gnu"... > (gdb) list 1 > 1 #include > 2 > 3 int main (int argc, char **argv) > 4 { > 5 return 0; > 6 } > (gdb) set listsize 0 > (gdb) list 1 > (gdb) > > vs current gdb: > > >./gdb ~/gdb/tests/main32 > GNU gdb (GDB) 7.1.50.20100601-cvs > Copyright (C) 2010 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-unknown-linux-gnu". > For bug reporting instructions, please see: > ... > Reading symbols from /home/pedro/gdb/tests/main32...done. > (gdb) set listsize 0 > (gdb) list 1 > 1 #include > 2 > 3 int main (int argc, char **argv) > 4 { > 5 return 0; > 6 } > (gdb) > > >> I'm not sure what to do with this test... > Ah, so it looks like a false pass, and I should make it fail.