From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-35742-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 16057 invoked by alias); 1 Oct 2009 12:11:42 -0000
Received: (qmail 16047 invoked by uid 22791); 1 Oct 2009 12:11:41 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mout2.freenet.de (HELO mout2.freenet.de) (195.4.92.92)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 12:11:37 +0000
Received: from [195.4.92.10] (helo=0.mx.freenet.de) 	by mout2.freenet.de with esmtpa (ID ralf.corsepius@freenet.de) (port 25) (Exim 4.69 #92) 	id 1MtKVF-0007CE-8u; Thu, 01 Oct 2009 14:11:21 +0200
Received: from hsi-kbw-078-043-063-233.hsi4.kabel-badenwuerttemberg.de ([78.43.63.233]:64475 helo=[192.168.1.104]) 	by 0.mx.freenet.de with esmtpsa (ID ralf.corsepius@freenet.de) (TLSv1:AES256-SHA:256) (port 465) (Exim 4.69 #94) 	id 1MtKVF-00081r-3q; Thu, 01 Oct 2009 14:11:21 +0200
Message-ID: <4AC49C67.9080502@rtems.org>
Date: Thu, 01 Oct 2009 12:11:00 -0000
From: Ralf Corsepius <ralf.corsepius@rtems.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3
MIME-Version: 1.0
To: Andreas Schwab <schwab@redhat.com>
CC: Pierre Muller <muller@ics.u-strasbg.fr>,   'Ralf Corsepius' <ralf.corsepius@rtems.org>,  'Joel Brobecker' <brobecker@adacore.com>, gdb@sourceware.org,   'Jan Kratochvil' <jan.kratochvil@redhat.com>,  'Tom Tromey' <tromey@redhat.com>
Subject: Re: GDB 6.8.92 available for testing
References: <20090930204828.GB31446@adacore.com> <4AC41F44.1040502@rtems.org> 	<m3ljjva3tl.fsf@hase.home> 	<002e01ca427a$5f1363b0$1d3a2b10$@u-strasbg.fr> <m3bpkra1vk.fsf@hase.home>
In-Reply-To: <m3bpkra1vk.fsf@hase.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00015.txt.bz2

On 10/01/2009 11:40 AM, Andreas Schwab wrote:
> "Pierre Muller"<muller@ics.u-strasbg.fr>  writes:
>
>> Andreas,
>>
>> why don't you simply use this?
>> #if RL_VERSION_MAJOR>= 6
>>    extern int _rl_echoing_p;
>> #define readline_echoing_p _rl_echoing_p
>> #else
>>     extern int readline_echoing_p;
>> #endif
>>
>>    This would make your patch simpler, no?
>>
>> Is there a reason for replacing all
>> readline_echoing_p by _rl_echoing_p?
>
> As explained in the mail, I want to emphasize that it is an internal
> readline variable (as noticeable from the leading underscore).

Besides this, version checks are evil.

Ralf