From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1697 invoked by alias); 29 Jun 2008 15:05:02 -0000 Received: (qmail 1646 invoked by uid 22791); 29 Jun 2008 15:05:02 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 29 Jun 2008 15:04:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 650A92A96CA; Sun, 29 Jun 2008 11:04:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id d9JWmPblVE5U; Sun, 29 Jun 2008 11:04:40 -0400 (EDT) Received: from [127.0.0.1] (nile.gnat.com [205.232.38.5]) by rock.gnat.com (Postfix) with ESMTP id 39D332A96C9; Sun, 29 Jun 2008 11:04:40 -0400 (EDT) Message-ID: <4867A487.1030605@adacore.com> Date: Sun, 29 Jun 2008 15:05:00 -0000 From: Robert Dewar User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Stan Shebs , gdb@sourceware.org Subject: Re: Encouraging patch reviewers References: <48668628.8050904@earthlink.net> <20080629144758.GC11412@caradoc.them.org> In-Reply-To: <20080629144758.GC11412@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00310.txt.bz2 Daniel Jacobowitz wrote: > On Sat, Jun 28, 2008 at 11:42:48AM -0700, Stan Shebs wrote: >> At the GCC summit we discussed patch review a bit, and one of the >> thoughts was that people who are not official maintainers of anything >> will often study a posted patch, and get a good idea of whether it's >> desirable, needs fixes, etc, but then maybe don't say anything because it >> won't be an "official" opinion. But it really does help to post such >> reviews, and quite likely a maintainer will simply rubberstamp it, saving >> time all around. So speaking up really helps, but in looking at >> gdb/MAINTAINERS I don't see anything that explicitly encourages people to >> post their own reviews - it just says "anyone [...] may suggest changes or >> ask questions". Does anybody think we need stronger phrasing here, and if >> so, how should it read? > > I'd be happy with something stronger. I agree, we want to take advantage of anyone willing to put in this useful work, we don't want them to refrain because they are concerned that it is not appropriate, or they will be stepping on someones toes. >